-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36693 - Add new host status for RHEL lifecycle #10706
Fixes #36693 - Add new host status for RHEL lifecycle #10706
Conversation
Issues: #36693 |
aa4add9
to
32842cb
Compare
[test katello] |
@@ -44,6 +44,24 @@ def set_atomic_attributes | |||
def atomic? | |||
name.match(/.*atomic.*/i) | |||
end | |||
|
|||
def rhel_eos_schedule | |||
return nil unless name == "RedHat" # using name and not title so we get specifically RHEL, not rebuilds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to assume all RHEL OSes use "RedHat" as the name? Or do some use "RHEL" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems they are all RedHat
for RHEL 9, 8 and 7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chris1984 do you happen to know what the strings are for RHEL6 and RHEL5? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremylenz Should be good to go with 6 too:
irb(main):004:0> Operatingsystem.second
=> #<Redhat id: 6, major: "6", name: "RedHat", minor: "10", nameindicator: nil, created_at: "2023-09-01 13:51:18.161260000 +0000", updated_at: "2023-09-01 13:51:18.161260000 +0000", release_name: nil, type: "Redhat", description: nil, password_hash: [FILTERED], title: "RedHat 6.10">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
narrator voice They were not good to go.
6f54329
to
f02a7fc
Compare
aa96e14
to
a934cc9
Compare
Added maintenance_warn_date so RHEL7 should now show |
707ccb3
to
c31d1fb
Compare
fixed tests |
I saw this message in green color 😃 |
@lfu Made approaching maintenance a warning status (should be yellow now) and cleaned up |
7545b0c
to
55f149b
Compare
@lfu Updated -
|
d9e058d
to
419b1ff
Compare
419b1ff
to
b964203
Compare
b964203
to
dda2820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job 👍🏻
dda2820
to
195a265
Compare
195a265
to
ecb4d4a
Compare
What are the changes introduced in this pull request?
Katello::RhelLifecycleStatus
which tells you if your RHEL system is getting close to EOS (end of support).Considerations taken when implementing this change?
What are the testing steps for this pull request?
Register at least one RHEL host. It should get a RHEL lifecycle status immediately on registration.
CentOS and other OS hosts will show "N/A" for RHEL lifecycle status.
To force host status updates:
note: This will refresh RHEL lifecycle status only for RHEL hosts. This is expected.
View host statuses on the new host details page, or in Rails console:
subscription-manager repos
)rhel_lifecycle_status = full_support
, etc.)def self.to_status
inapp/models/katello/rhel_lifecycle_status.rb
def rhel_eos_schedule
inapp/models/katello/concerns/operatingsystem_extensions.rb