Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36625 - allow verify checksum for all repo types #10671

Merged

Conversation

ianballou
Copy link
Member

What are the changes introduced in this pull request?

Allows verifying checksums for all repo types. Looking at the APIs for different Pulp plugins, it appears they all support version repair.

Considerations taken when implementing this change?

All types should support version repair

What are the testing steps for this pull request?

Try a verify checksum sync for all kinds of Katello repositories. Yum and Debian were only supported in the past.

@theforeman-bot
Copy link

Issues: #36625

Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update this call since method params have changed to no longer validate validate_contents

validate_repo!(repo: repo,
                        source_url: source_url,
                        validate_contents: validate_contents,
                        skip_metadata_check: skip_metadata_check,
                        skip_candlepin_check: options.fetch(:skip_candlepin_check, false))

@ianballou ianballou force-pushed the 36625-container-verify-checksum branch 2 times, most recently from 9d6a04d to 46a1af4 Compare August 1, 2023 18:30
@ianballou
Copy link
Member Author

@sjha4 did some cleanup

@ianballou ianballou force-pushed the 36625-container-verify-checksum branch from 46a1af4 to 340f425 Compare August 1, 2023 19:30
Copy link
Member

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hammer sync --validate-content true now works for all the below content types I had on my box. Was able to verify the repair task in pulp and see the task progress etc as expected.
Screenshot from 2023-08-01 15-45-56

Ack 👍🏼

@ianballou
Copy link
Member Author

[test katello]

@ianballou ianballou merged commit 0310103 into Katello:master Aug 2, 2023
4 checks passed
@ianballou ianballou deleted the 36625-container-verify-checksum branch August 2, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants