Refs #36540 - Removed the unnecessary enablement migrator in master #10648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36540 |
This file was only needed for upgrading from 4.7/4.8 to 4.9 It is no longer needed for future updates. So removing from master
parthaa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tries to address the issues listed here
PR for Issue #36120 changed default enablement for custom repos. By default all custom repos got disabled in candlepin. However a migration task was provided to add overrides for existing custom repos.
The enablement migrator introduced in that PR is no longer necessary for 4.10 (which points to the correct master) so removing it.
Considerations taken when implementing this change?
We basically want say Default Enablement Migrator must only run for anything upto 4.9 but not after.
What are the testing steps for this pull request?
bundle exec rake katello:upgrades:4.9:update_custom_products_enablementshould not change the enablement of anything.