Fixes #36482 - Use string keys for accessing 'arch' and 'minor' in re… #10616
Conversation
|
Issues: #36482 |
| Katello::Content.substitute_content_path(arch: repo[:arch], | ||
| releasever: repo[:minor], | ||
| Katello::Content.substitute_content_path(arch: repo['arch'], | ||
| releasever: repo['minor'], | ||
| content_path: content_path) |
There was a problem hiding this comment.
Can we do something like:
repo_hash = HashWithIndifferentAccess.new(repo) and then we won't have to worry about symbol or string key access?
Thoughts?
There was a problem hiding this comment.
I initially wanted this approach, but decided against it because I wasn't sure about performance characteristics in case results or repo is particularly large.
If you think it's fine, I'll happily make the change.
There was a problem hiding this comment.
I like @wbclark 's approach better. That is more because contents of the repo results themselves are not returned. We are instead returning a list of string paths
Only thing I 'd suggest adding is a Unit test.
|
Able to enable upstream repos with substitutions now. Test based Ack 👍🏼 |
wbclark
force-pushed
the
36482_cdn_hash_key_symbols
branch
from
8e6da99
to
f1f7f58
Compare
|
Let's give this a shot... |
wbclark
force-pushed
the
36482_cdn_hash_key_symbols
branch
from
f1f7f58
to
5c11c02
Compare
…po hash