Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35959 - prepare to use structured publisher for deb content #10420

Closed
wants to merge 4 commits into from

Conversation

sbernhard
Copy link
Member

What are the changes introduced in this pull request?

Considerations taken when implementing this change?

What are the testing steps for this pull request?

@theforeman-bot
Copy link

Issues: #35959

@sbernhard sbernhard changed the title Fixes #35959 - prepare to use structured publisher for deb content Draft: Fixes #35959 - prepare to use structured publisher for deb content Jan 17, 2023
@sjha4
Copy link
Member

sjha4 commented Mar 1, 2023

@sbernhard : Is this part of a bigger RFE? For this PR is there a way to test this? Code LGTM as far as non-deb content goes but I am not sure how it impacts deb repos.

@sbernhard
Copy link
Member Author

@sbernhard : Is this part of a bigger RFE? For this PR is there a way to test this? Code LGTM as far as non-deb content goes but I am not sure how it impacts deb repos.

To use this, we need to change the subscription-manager, too. We are working on it.

@sbernhard
Copy link
Member Author

Together with candlepin/subscription-manager#3223 it works.

Unfortunately, it still has one limitation:

We need packages uploaded to pulp_deb to be added to some fall back component by default.
Otherwise we cannot convert to using structured repos in subscription-manager.
In pulp_deb terms this means, we need to create Release, ReleaseComponent, and/or PackageReleaseComponent as needed when uploading a package.

@sbernhard sbernhard changed the title Draft: Fixes #35959 - prepare to use structured publisher for deb content Fixes #35959 - prepare to use structured publisher for deb content Apr 19, 2023
@@ -434,6 +434,23 @@ def format_arches
end
end

def format_custom_content_path
path = custom_content_path
if content_type == ::Katello::Repository::DEB_TYPE && SETTINGS[:katello][:use_deb_structured_publisher] == true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long term story: we want to get rid of this setting again.
We need this setting so that old sub-man works. If "all users" use the new sub-man (see candlepin/subscription-manager#3223 ) then we would remove this check setting check again. Additionally, we would remove to do a simple publish in pulp which would increase the performance a lot.

@ianballou
Copy link
Member

Is this ready to be merged? I'm curious what the testing steps would be from the debian side. After applying the sub-man patch and we sync a debian repo, what would we be looking for in the distribution path?

@quba42
Copy link
Contributor

quba42 commented Jun 14, 2023

@ianballou I think it is not quite ready to be merged, since we are still working on other building blocks to complete this story.

@sbernhard Perhaps we can convert this to "draft PR" status until we are ready to add some testing instructions.

@sbernhard sbernhard marked this pull request as draft June 14, 2023 08:16
@ianballou
Copy link
Member

Thanks for moving it to a draft! Mind pinging us when it's ready?

distributions.concat(' default')
end

super.merge({policy: policy, distributions: distributions})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
super.merge({policy: policy, distributions: distributions})
super.merge({distributions: distributions})

This is a rebase error.

sbernhard pushed a commit to ATIX-AG/katello that referenced this pull request Sep 18, 2023
sbernhard pushed a commit to ATIX-AG/katello that referenced this pull request Feb 29, 2024
sbernhard pushed a commit to ATIX-AG/katello that referenced this pull request Mar 8, 2024
@sbernhard
Copy link
Member Author

Closed in favor of #11058

@sbernhard sbernhard closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants