Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

python2-tracer 0.6.12 only in EPEL and F26 #521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Aug 31, 2017

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • 4f96237 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@ehelms
Copy link
Member Author

ehelms commented Aug 31, 2017

@sean797 Seem reasonable to you or can we relax the tracer version requirement?

Copy link
Member

@sean797 sean797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we need a minimum of that version for FrostyX/tracer@d2f5164 .now() (used in https://github.com/Katello/katello-agent/blob/master/src/yum-plugins/tracer_upload.py#L36)

Weird I can't see it in the repos but https://bodhi.fedoraproject.org/updates/FEDORA-2016-3f9b4e3c43 shows it should have been pushed to stable.

@ehelms
Copy link
Member Author

ehelms commented Aug 31, 2017

@sean797 Ahhh, its in the updates repository (now the Everything repo) [1]. I will just add that to repoclosure for F25 which should mean this check is no longer needed. What I would ask if you would be willing to update the katello client docs to include this requirement for F25?

[1] http://ftp.linux.ncsu.edu/pub/fedora/linux/updates/25/x86_64/p/

@sean797
Copy link
Member

sean797 commented Sep 1, 2017

Sure, but I'm not sure they need updating? The updates repo should be enabled on all Fedora installs by default.

Do you want to update you're change to > 22 since its only available on F23+.

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • e60a4f8 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@ehelms
Copy link
Member Author

ehelms commented Sep 1, 2017

@sean797 Updated

@@ -161,7 +161,7 @@ exit 0
%attr(750, root, root) %{_sbindir}/katello-enabled-repos-upload
%{_prefix}/lib/yum-plugins

%if 0%{?fedora} > 18 || 0%{?rhel} > 6
%if 0%{?fedora} > 25 || 0%{?rhel} > 6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo ? The other lines are 24

@ehelms
Copy link
Member Author

ehelms commented Nov 6, 2017

These packages and code have all moved to foreman-packaging rpm/develop under a katello subfolder. Please re-open your PR against it to ensure there is no data loss between the repositories. The code in this repository will be subsequently removed -- #575

@ehelms ehelms closed this May 21, 2018
@ehelms ehelms reopened this May 21, 2018
@komidore64
Copy link
Contributor

[test katello-packaging]

1 similar comment
@komidore64
Copy link
Contributor

[test katello-packaging]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants