Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37721 - Hammer erratum list output is wrong when using content-view filter #945

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Aug 9, 2024

Add some validations around --content-view filter for errata lists.

  1. If you're using cv-name, hammer needs to know org id to fetch the cv-id
  2. Errata belongs to cv versions and not cv directly so if you're using --content-view(-id) filter, you also need to provide --environment params to fetch the exact cvv.
  3. The --environment param was not working. Only the environment-id param was. This should fix that.

To test this create a CV with repo with some errata and publish it to a version promoted to any environment.

Then run:
hammer erratum list --content-view='RHEL7' --cve="CVE-2023-45288" --lifecycle-environment-id=1
with different params passed to m,ake sure it all looks ok.

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well! I tested the scenarios in the redmine and then some more on top of that.

Also double checked that the content-view-filter + available-for filters still work, just to be safe.

@sjha4 sjha4 merged commit a782484 into Katello:main Aug 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants