Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36689 #903

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Fixes #36689 #903

merged 1 commit into from
Sep 5, 2023

Conversation

jpasqualetto
Copy link
Member

Ensure permissions on listing file is 644

@theforeman-bot
Copy link

Issues: #36689

@chris1984
Copy link
Member

Looks like we have a rubocop failure:

Offenses:

lib/hammer_cli_katello/content_export_helper.rb:103:22: C: Use 0o for octal literals.
          File.chmod(0644, "#{dir}/listing")
                     ^^^^

262 files inspected, 1 offense detected
Error: Process completed with exit code 1.

@jpasqualetto
Copy link
Member Author

Looks like we have a rubocop failure:

Offenses:

lib/hammer_cli_katello/content_export_helper.rb:103:22: C: Use 0o for octal literals.
          File.chmod(0644, "#{dir}/listing")
                     ^^^^

262 files inspected, 1 offense detected
Error: Process completed with exit code 1.

I fixed it and pushed the changed.

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks @jpasqualetto

@chris1984 chris1984 merged commit 1fa5f0c into Katello:master Sep 5, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants