Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BPM and Artists #44

Merged
merged 1 commit into from
Sep 2, 2023
Merged

BPM and Artists #44

merged 1 commit into from
Sep 2, 2023

Conversation

codello
Copy link
Contributor

@codello codello commented Aug 30, 2023 •
edited
Loading

This PR introduces two changes to the API:

  • The BPM of a song are now exposed via the bpm field
  • Songs can now have multiple artists instead of a single artist. The first artist is always the primary artist.

Closes #39

@codello codello added the api Related to the Karman API label Aug 30, 2023
@codello codello added this to the Version 0.1 milestone Aug 30, 2023
@codello codello merged commit a90bd77 into main Sep 2, 2023
12 checks passed
@codello codello deleted the feature/bpm-artists branch September 2, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenowi-dev kenowi-dev kenowi-dev approved these changes

Assignees
No one assigned
Labels
api Related to the Karman API
Projects
None yet
Milestone
Version 0.1
Development

Successfully merging this pull request may close these issues.

Multiple Artists per Song
2 participants
@codello @kenowi-dev