Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust build script and properties for use with dual audio releases #1

Open
wants to merge 7 commits into
base: dual-audio
Choose a base branch
from

Conversation

MarioLuigi0404
Copy link

Possibly not the most elegant approach, but adds functions for merging S&S tracks, configures mux function and sub properties file for two audio tracks and S&S sub track.

Of note, muxing the S&S track requires opsync/edsync lines to be in files other than dialogue.

(Not strictly tested but made based on a separate multi-audio project repo that I know does work. If things are broken, yell at me.)

@petzku
Copy link
Contributor

petzku commented Jun 17, 2024

Of note, muxing the S&S track requires opsync/edsync lines to be in files other than dialogue.

it may be cleaner to simply strip the dialogue lines from these tracks, rather than merge them separately. this also avoids duplicating the merge logic:

fun EventLine.isDialogue(): Boolean {
    return Regex("Default|Alt") in this.style
}
subs {
// -- snip --
    // Build signs & songs track
    val forced by task<ASS> {
        from(cleanmerge.item())
        ass {
            events.lines.removeIf { it.isDialogue() }
        }
    }

Rather than making a new merge from scratch, now takes cleanmerge and strips dialogue.
@MarioLuigi0404
Copy link
Author

Fixes issue with S&S requiring sync points in a non-dialogue file, though also purges any potential foreign dialogue that should be in the S&S track unless it is given a style name that doesn't get picked up by the dialogue regex. I don't think it's much of an issue though, since handling for that wasn't really implemented to begin with.

@petzku
Copy link
Contributor

petzku commented Jun 17, 2024

If that was desired, we could merge in a Forced.ass later on in the chain. Definitely worth thinking about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants