fix(KUI-1369): noIndexMiddleware and noIndexMiddleware.test has been added to make sure that URL with aap*. is not indexed by google #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added to make sure that URL with aap*. is not indexed by google
amirhossein-haerian
requested review from
belanglos,
karlandindrakryggen and
axelbjo
as code owners
belanglos
approved these changes
Jun 24, 2024
| noIndexMiddleware(req, res, next) | ||
|
|
||
| expect(res.getHeader('X-Robots-Tag')).toBeUndefined() | ||
| expect(next).toHaveBeenCalledTimes(1) |
There was a problem hiding this comment.
This is a good solution. The reason why this works in KP, is that we there use jest-extended
In KP's jest.config.js:
setupFilesAfterEnv: ['jest-extended/all'],
If you want, you can also include jest-extended in kursinfo-web and include it as above.
There was a problem hiding this comment.
Thanks for sharing this, I have added the est-extended package and the required config. I also changed "toHaveBeenCalledTimes()" to "toHaveBeenCalledOnce()".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to make some tiny changes comparing (KTH/kopps-public-react-web@56e9d6f):