Fix #195: clone the srfAttachNode when reversing a surface attachment during re-root #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-this is more similar to the idea behind the stock code, except that instead of moving the part's actual srfAttachNode we just create a new one in the AttachNode list. The stock ReverseSrfNodeDirection also, ironically, does not actually flip the orientation of the node. -Remove Stock ChangeSrfNodePosition entirely because it's completely broken (as the previous patch had been doing) -This approach seems to work really well right up until you save & load the craft. The parts come back in the right positions, but the fake node no longer exists so other things break.
|
hrm there seems to be some extra changes in here that shouldn't be :/ let me see if I can clean that up |
-this is more similar to the idea behind the stock code, except that instead of moving the part's actual srfAttachNode we just create a new one in the AttachNode list. The stock ReverseSrfNodeDirection also, ironically, does not actually flip the orientation of the node.
JonnyOThan
force-pushed
the
fix-195-clone-srfattachnode
branch
from
302b4c4
to
8fe18ca
Compare
…oddingLibs/KSPCommunityFixes into fix-195-clone-srfattachnode
|
Well, as I mentioned in the related issue, my opinion is that this is way too hacky and is very likely to cause weird side effect for any piece of code expecting a surface attached part to be attached by the surface attach node. Doing a quick GH search, I find way too many pieces of code doing checks of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different take on ReRootPreserveSurfaceAttach. Slightly closer to the apparent intended behavior from stock.