Support icons from libraries for deb and rpm #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the course of discussing #4073, it dawned on me that Linux systems support icon themes, and typical
.desktopfiles enable this by using a symbolic name for their icons instead of an absolute path. So I spent a while reading up on how that works:Changes
.desktopfiles use the symbolic nameIcon=ckaninstead of the absolute pathIcon=/usr/share/icons/ckan.ico, to allow icon libraries to supply their own custom icons for CKAN/usr/share/icons/ckan.ico; instead, they install our variously sizedckan-16.png,ckan-32.png, ... ,ckan-256.pngfiles to/usr/share/icons/hicolor/16x16/apps/ckan.png(and so on for all the sizes), because this is the path for default application-supplied icons according to the spec