Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log4net, newtonsoft deps from deb package #3900

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

HebaruSan
Copy link
Member

Problem

Trying to install the .deb on Debian 12 fails with a message indicating log4net is missing:

root@MartinPC:/home/martin/Downloads# apt install ckan
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 ckan : Depends: liblog4net1.2-cil but it is not installable
E: Unable to correct problems, you have held broken packages.

Cause

The latest release of Debian seems to no longer include this package; "bookworm" doesn't show up in the package search listing:

https://packages.debian.org/search?searchon=names&keywords=liblog4net1.2-cil

However, our build process repacks log4net into ckan.exe, so we shouldn't need it to be installed in the OS:

image

Changes

Now log4net and newtonsoft are no longer listed as requirements for the .deb, because they are both repacked into the ckan.exe assembly. This should allow the .deb to be installed on Debian 12 and any other .deb-based OS that drops this package.

Fixes #3896.

@HebaruSan HebaruSan added Bug Something is not working as intended Easy This is easy to fix Linux Issues specific for Linux Package: deb Issues affecting the Debian packaging labels Sep 6, 2023
Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen the discussion, looks great! Thanks @HebaruSan

@HebaruSan HebaruSan merged commit ff291b1 into KSP-CKAN:master Sep 6, 2023
10 checks passed
@HebaruSan HebaruSan deleted the fix/deb-deps branch September 6, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Easy This is easy to fix Linux Issues specific for Linux Package: deb Issues affecting the Debian packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debian 12 bookworm doesn't have liblog4net
2 participants