Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Causes
Motivation
We have a very old
TODO
item here:CKAN/GUI/Model/ModList.cs
Line 172 in 1a884fe
This is not a very good place for it (it would be architecturally better for this class to be a pure data model, and this function could be called with a changeset that isn't meant to be applied to a grid), but the idea makes sense because showing users which mods will be removed could be helpful.
Changes
strikeoutfont on the main mod list:TODO
regardingModList.HandleTooManyProvides
is resolved by deleting that delegate definition, which is no longer in use