Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing KSP2 exe #3854

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Handle missing KSP2 exe #3854

merged 1 commit into from
Jul 3, 2023

Conversation

HebaruSan
Copy link
Member

Problem

A user uninstalled KSP2 and reported this on Discord:

image

Cause

FileVersionInfo.GetVersionInfo throws an exception when the file doesn't exist.

Changes

Now we check File.Exists so the exception won't be thrown.

@HebaruSan HebaruSan added Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN labels Jul 2, 2023
@HebaruSan HebaruSan requested a review from techman83 July 2, 2023 21:31
techman83
techman83 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'll do it! Thanks @HebaruSan

@HebaruSan HebaruSan merged commit 1ecec0a into KSP-CKAN:master Jul 3, 2023
@HebaruSan HebaruSan deleted the fix/ksp2-exe-not-found branch July 3, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techman83 techman83 techman83 approved these changes

Assignees
No one assigned
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HebaruSan @techman83