Merge #4059 Launch wiki when Windows users select dev updates

KSP-CKAN · Mar 15, 2024 · 4694463 · 4694463
2 parents f24bf65 + 220b99c
commit 4694463
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,7 +6,7 @@ All notable changes to this project will be documented in this file.
 
 ### Features
 
-- [Updater] Support dev builds for auto updater (#3997, #4008 by: HebaruSan)
+- [Updater] Support dev builds for auto updater (#3997, #4008, #4059 by: HebaruSan)
 - [GUI] Sort mods satisfying the same recommendation by download count (#4007 by: HebaruSan)
 - [Multiple] Alternate game command lines and Steam refactor (#4010, #4013, #4028 by: HebaruSan)
 - [Multiple] Recommendations usability improvements (#4025 by: HebaruSan)

diff --git a/Cmdline/Action/Upgrade.cs b/Cmdline/Action/Upgrade.cs
@@ -66,6 +66,12 @@ public int RunCommand(CKAN.GameInstance instance, object raw_options)
                                || (!options.stable_release && (config.DevBuilds ?? false));
                 if (devBuild != config.DevBuilds)
                 {
+                    if (!config.DevBuilds.HasValue && devBuild && Platform.IsWindows)
+                    {
+                        // Tell Windows users about malware scanner's false positives
+                        // and how to disable it, if they feel safe doing it
+                        Utilities.ProcessStartURL(HelpURLs.WindowsDevBuilds);
+                    }
                     config.DevBuilds = devBuild;
                     user.RaiseMessage(
                         config.DevBuilds ?? false

diff --git a/Core/HelpURLs.cs b/Core/HelpURLs.cs
@@ -11,6 +11,7 @@ public static class HelpURLs
         public const string ModPacks = "https://github.com/KSP-CKAN/CKAN/wiki/Sharing-a-modlist-%28metapackages%29";
         public const string AuthTokens = "https://github.com/KSP-CKAN/CKAN/wiki/Adding-a-GitHub-API-authtoken";
         public const string CertificateErrors = "https://github.com/KSP-CKAN/CKAN/wiki/SSL-certificate-errors";
+        public const string WindowsDevBuilds = "https://github.com/KSP-CKAN/CKAN/wiki/Using-dev-builds-on-Windows";
 
         public const string CloneFakeInstances = "https://github.com/KSP-CKAN/CKAN/pull/2627";
         public const string DeleteDirectories = "https://github.com/KSP-CKAN/CKAN/pull/2962";

diff --git a/GUI/Main/MainAutoUpdate.cs b/GUI/Main/MainAutoUpdate.cs
@@ -31,6 +31,12 @@ private void AutoUpdatePrompts(IConfiguration   coreConfig,
                 coreConfig.DevBuilds = !YesNoDialog(Properties.Resources.MainReleasesOrDevBuildsPrompt,
                                                     Properties.Resources.MainReleasesOrDevBuildsYes,
                                                     Properties.Resources.MainReleasesOrDevBuildsNo);
+                if (coreConfig.DevBuilds.Value && Platform.IsWindows)
+                {
+                    // Tell Windows users about malware scanner's false positives
+                    // and how to disable it, if they feel safe doing it
+                    Utilities.ProcessStartURL(HelpURLs.WindowsDevBuilds);
+                }
             }
         }