cxx-qt-build: Export .qmltypes and qmldir for use with external tooling #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to get away without whole-archive in CMake by declaring an OBJECT library instead.
Otherwise, Ninja will complain, as it needs **some** rule to build the target, even if that rule does nothing.
This caused a build failure when not building a binary. Linking the object file in shouldn't produce issues.
And don't redirect the first build output to /dev/null This should allow us to see what exactly is failing in CI.
Otherwise the linker order doesn't work out and the linker cannot resolve the qt_static_plugin_*** functions
It's much more concise than using File::create followed by write!
This can be used to e.g. register custom types, import plugins, declare modules, etc.
This reverts commit 40f5ad1. We are now building and linking object files directly, which works nicely with CMake and seems to work for Rust as well.
This may be a clippy bug, as `cargo expand` tells me the generated functions do indeed have a `# Safety` section in their documentation. The `# Safety` sections also show up in the output of `cargo doc`. So it's unclear why clippy is complaining.
This way we don't need a separate object file and CMake target for this.
|
For we might need to change that code to be readonly property RustProperties rustProperties: RustProperties {}instead of RustProperties {
id: rustProperties
}But there are likely other places that complain about this too. For the other issues looks maybe related to missing setting a version in the plugin ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve support for qmllint and qmlls
Currently we get this ouput from qmllint after this change:
Depends on #978