signals: use #[must_use] when returning a QMetaObjectConnectionGuard #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
force-pushed
the
930-must-use-for-connection-guard
branch
from
3b06fee
to
d442859
Compare
greaka
reviewed
Apr 18, 2024
There was a problem hiding this comment.
It is easy to miss adding #[must_use] when adding a new signal.
By annotating QMetaObjectConnectionGuard instead, the must_use warning will automatically be applied to every function that returns that struct.
While both changing the return type and adding new functions is equally unlikely, putting must_use on the type also helps downstream users when working with this type.
|
Good idea, i'll try that :-) |
ahayzen-kdab
force-pushed
the
930-must-use-for-connection-guard
branch
from
d442859
to
578926c
Compare
Before we used to return a QMetaObjectConnection which used to disconnection now we have two types, so ensure #[must_use] is used when a guard is returned.
ahayzen-kdab
force-pushed
the
930-must-use-for-connection-guard
branch
from
578926c
to
5f094e7
Compare
LeonMatthesKDAB
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we used to return a QMetaObjectConnection which used to disconnection now we have two types, so ensure #[must_use] is in the right place.
Closes #930