qtypes: add support for Qt alias types that don't match #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
commented
Mar 28, 2024
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
from
e8826f5
to
e409d32
Compare
Montel
reviewed
Mar 29, 2024
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
from
e409d32
to
e5daff8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11949 11949
=========================================
Hits 11949 11949 ☔ View full report in Codecov by Sentry. |
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
2 times, most recently
from
debf9b7
to
79cc8fe
Compare
ahayzen-kdab
commented
Oct 11, 2024
ahayzen-kdab
commented
Oct 11, 2024
crates/cxx-qt-lib/src/core/qtypes.rs
Outdated
Comment on lines
14
to
15
| #[cxx_name = "qint64"] | ||
| type QInt64 = super::QInt64; |
There was a problem hiding this comment.
In Rust should we be calling these QInt64 and QUInt64 or should we copy Qt and use lowercase qint64 and quint64 ? 🤔
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
3 times, most recently
from
6a21207
to
c67af09
Compare
ahayzen-kdab
changed the title
Some times don't match the Rust types so add these missing types. Closes KDAB#882
ahayzen-kdab
force-pushed
the
882-add-qtypes
branch
from
c67af09
to
709d25d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #882