examples: add basic widgets example #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
force-pushed
the
577-extern-cpp-qt-block
branch
2 times, most recently
from
d33623c
to
27851e2
Compare
ahayzen-kdab
commented
Jul 31, 2023
ahayzen-kdab
force-pushed
the
577-extern-cpp-qt-block
branch
from
27851e2
to
81a04e6
Compare
ahayzen-kdab
force-pushed
the
577-extern-cpp-qt-block
branch
from
81a04e6
to
461bfaf
Compare
ahayzen-kdab
changed the title
ahayzen-kdab
commented
Jan 15, 2024
ahayzen-kdab
commented
Jan 15, 2024
ahayzen-kdab
force-pushed
the
577-extern-cpp-qt-block
branch
from
461bfaf
to
8574b42
Compare
ahayzen-kdab
force-pushed
the
577-extern-cpp-qt-block
branch
from
8574b42
to
525e1df
Compare
Merged
ahayzen-kdab
force-pushed
the
577-extern-cpp-qt-block
branch
from
525e1df
to
58abe41
Compare
ahayzen-kdab
commented
Apr 16, 2024
| use cxx_qt_lib::QString; | ||
| use cxx_qt_lib_extras::{QApplication, QPushButton}; | ||
|
|
||
| fn main() { |
There was a problem hiding this comment.
we should have some kind of test as well, even if C++ to see if this works, unsure how so far....
ahayzen-kdab
force-pushed
the
577-extern-cpp-qt-block
branch
4 times, most recently
from
b9dcbfc
to
dae15d9
Compare
ahayzen-kdab
commented
Apr 17, 2024
| #[qobject] | ||
| type QPushButton; | ||
|
|
||
| // TODO: we should use upcasting methods here and implement QAbstractButton and QWidget |
There was a problem hiding this comment.
we should figure out how upcasting is going to work, as otherwise we are going to duplicate a load of methods in the widgets world
ahayzen-kdab
force-pushed
the
577-extern-cpp-qt-block
branch
from
dae15d9
to
48a9cd3
Compare
ahayzen-kdab
commented
Oct 8, 2024
Comment on lines
+14
to
+15
| // TODO: we should really pass a parent in here | ||
| let mut push_button = QPushButton::new(); |
There was a problem hiding this comment.
Should we use UniquePtr or should we use raw pointer and set a parent like Qt, or should we support both?
ahayzen-kdab
force-pushed
the
577-extern-cpp-qt-block
branch
from
48a9cd3
to
db51492
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11953 11953
=========================================
Hits 11953 11953 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of hacks, but we can launch a
QPushButton!I'll likely pick things off from this branch as separate pull requests over time.