fix sonar issues

KBTG-Kampus-ClassNest-SE-Java · Mar 31, 2024 · 5570851 · 5570851
1 parent 5a6261e
commit 5570851
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/kbazaar/src/main/java/com/kampus/kbazaar/cart/CartService.java b/kbazaar/src/main/java/com/kampus/kbazaar/cart/CartService.java
@@ -1,7 +1,6 @@
 package com.kampus.kbazaar.cart;
 
 import com.kampus.kbazaar.cartitem.CartItemService;
-import com.kampus.kbazaar.promotion.PromotionApplyCartRequest;
 import com.kampus.kbazaar.shopper.Shopper;
 import com.kampus.kbazaar.shopper.ShopperRepository;
 import java.util.List;
@@ -14,11 +13,6 @@ public class CartService {
 
     private final ShopperRepository shopperRepository;
 
-    public CartResponse applyCartPromotion(
-            String username, PromotionApplyCartRequest promotionApplyCartRequest) {
-        return new CartResponse();
-    }
-
     public CartService(ShopperRepository shopperRepository, CartItemService cartItemService) {
         this.shopperRepository = shopperRepository;
         this.cartItemService = cartItemService;
@@ -27,7 +21,7 @@ public CartService(ShopperRepository shopperRepository, CartItemService cartItem
     // get all carts
     public List<CartResponse> getAllCart() {
 
-        // getb all user
+        // get all user
         List<String> usernameList =
                 shopperRepository.findAll().stream().map(Shopper::getUsername).toList();
 

diff --git a/kbazaar/src/main/java/com/kampus/kbazaar/promotion/PromotionService.java b/kbazaar/src/main/java/com/kampus/kbazaar/promotion/PromotionService.java
@@ -19,16 +19,13 @@ public class PromotionService {
 
     private final CartItemService cartItemService;
 
-    private final CartRepository cartRepository;
-
     public PromotionService(
             PromotionRepository promotionRepository,
             CartItemRepository cartItemRepository,
             CartRepository cartRepository,
             CartItemService cartItemService) {
         this.promotionRepository = promotionRepository;
         this.cartItemRepository = cartItemRepository;
-        this.cartRepository = cartRepository;
         this.cartItemService = cartItemService;
     }
 
@@ -57,8 +54,6 @@ public CartResponse applyPromotion(String username, Promotion promotion) {
             }
         }
 
-        CartResponse response = cartItemService.getCartByUsername(username);
-
-        return response;
+        return cartItemService.getCartByUsername(username);
     }
 }