Clean up and add more docs #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is easy for the sample YAMLs scaffolded by kubebuilder to become out of date, often missing new fields or defaulted values. This change uses both the PolicyCore and FakePolicy samples in the fakepolicy "basic" suite of tests, ensuring that they are kept up to date. Signed-off-by: Justin Kulikauskas <[email protected]>
The RBAC resources for PolicyCore were already incomplete, and are not used, so they have now been removed from the config/ folder. The boilerplate.go.txt was looking very lonely in the hack/ folder, which was taking up valuable space on the GitHub landing page, so it has been moved into the config/ folder. Signed-off-by: Justin Kulikauskas <[email protected]>
Signed-off-by: Justin Kulikauskas <[email protected]>
|
Code Coverage Report for this branch (might be slow to update): |
Signed-off-by: Justin Kulikauskas <[email protected]>
JustinKuli
force-pushed
the
clean-and-doc
branch
from
7bf6610
to
190cbf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to the "polish" of the repository.