"Traditional" Compliance Events #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetCondition and something like UpdateCondition have worked well in the OperatorPolicy. The fakepolicy tests have been updated to use conditions instead of the various special fields it was collecting in its status. Signed-off-by: Justin Kulikauskas <[email protected]>
|
Code Coverage Report for this branch (might be slow to update): |
PR Reviewer Guide 🔍
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
AI Suggestions Score
|
The test toolkit and courtesies are things that other policies could use in their tests. The remaining functions in the utils.go file are more specifically just for fakepolicy. In preparation for more tests, the existing tests have been moved into a separate package/suite. In particular, since some of them require very specific details in the cluster (exact namespaces, configmaps, and no extras), this lets them be run in a more isolated way. Signed-off-by: Justin Kulikauskas <[email protected]>
JustinKuli
force-pushed
the
comp-event-sending
branch
from
45e34f7
to
f05d46b
Compare
Many details about the event emitted and functions that verify the form of the fields are taken from other policy repositories. Many of the helpful functions added to the toolkit are similarly not original, but are an evolution of functions used in other repositories' tests. Signed-off-by: Justin Kulikauskas <[email protected]>
JustinKuli
force-pushed
the
comp-event-sending
branch
from
f05d46b
to
a2f80d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Kubernetes events that the policy framework uses to track and aggregate compliance, and includes test utilities for them.