Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other dark theme more XD #782

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions res/values/arrays.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
<item>@string/pref_theme_e_monet</item>
<item>@string/pref_theme_e_monetlight</item>
<item>@string/pref_theme_e_monetdark</item>
<item>@string/pref_theme_e_pasteldarkblue</item>
</string-array>
<string-array name="pref_theme_values">
<item>system</item>
Expand All @@ -45,6 +46,7 @@
<item>monet</item>
<item>monetlight</item>
<item>monetdark</item>
<item>pasteldarkblue</item>
</string-array>
<string-array name="pref_swipe_dist_entries">
<item>@string/pref_swipe_dist_e_very_short</item>
Expand Down
1 change: 1 addition & 0 deletions res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ This application contains no ads, doesn't make any network requests and is Open
<string name="pref_theme_e_monet">Monet (System)</string>
<string name="pref_theme_e_monetlight">Monet (Light)</string>
<string name="pref_theme_e_monetdark">Monet (Dark)</string>
<string name="pref_theme_e_pasteldarkblue">Pastel Dark (blue)</string>
<string name="pref_swipe_dist_e_very_short">Very short</string>
<string name="pref_swipe_dist_e_short">Short</string>
<string name="pref_swipe_dist_e_default">Normal</string>
Expand Down
18 changes: 18 additions & 0 deletions res/values/themes.xml
Original file line number Diff line number Diff line change
Expand Up @@ -202,5 +202,23 @@
<item name="colorSubLabel">@android:color/system_neutral1_300</item>
<item name="emoji_button_bg">?colorKeyActivated</item>
<item name="emoji_color">@android:color/system_accent1_900</item>
</style>
<style name="PastelDarkBlue" parent="@style/BaseTheme">
<item name="android:isLightTheme">false</item>
<item name="colorKeyboard">#333334</item>
<item name="colorKey">#11111B</item>
<item name="colorKeyActivated">#22222A</item>
<item name="colorLabel">#CDD6F4</item>
<item name="colorLabelActivated">#ffffff</item>
<item name="colorLabelLocked">#8AADF4</item>
<item name="colorSubLabel">#DEE5E3</item>
<item name="keyBorderWidth">1.0dip</item>
<item name="keyBorderWidthActivated">1.0dip</item>
<item name="keyBorderColorLeft">#8AADF4</item>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this theme could be a great candidate for the "monet" color system that uses the colors from the system theme.

Here's an experimentation:

	<style name="PastelDarkBlue" parent="@style/BaseTheme">
    <item name="android:isLightTheme">false</item>
    <item name="colorKeyboard">#333334</item>
    <item name="colorKey">#11111B</item>
    <item name="colorKeyActivated">#22222A</item>
    <item name="colorLabel">@android:color/system_accent1_300</item>
    <item name="colorLabelActivated">#ffffff</item>
    <item name="colorLabelLocked">#8AADF4</item>
    <item name="colorSubLabel">@android:color/system_accent1_500</item>
    <item name="keyBorderWidth">1.0dip</item>
    <item name="keyBorderWidthActivated">1.0dip</item>
    <item name="keyBorderColorLeft">@android:color/system_accent1_400</item>
    <item name="keyBorderColorTop">@android:color/system_accent1_400</item>
    <item name="keyBorderColorRight">@android:color/system_accent1_400</item>
    <item name="keyBorderColorBottom">@android:color/system_accent1_400</item>
    <item name="emoji_button_bg">?colorKeyActivated</item>
    <item name="emoji_color">#000000</item>
  </style>

shot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, "monet" is a style that is themed according to the colors of the material you? , well, actually if it was born from there is the theme but it was actually to combine with the discord

For me it's fine (the current "monet" reminded me when you put random colors in the CMD with [Color AF] :v)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have to try my black friend's phone ( It's autoracist so I don't know if it counts as self-love or that the CPU celeron did him wrong) that has "android 13" (my hell range [it gives to cook on the screen] is android 10 XD)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for trying the monet thing but I think we should drop this idea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it on hold, I'm not going to abandon it completely, (what I did abandon is the accessibility, I don't understand it) in what I have free (after finishing some soundtracks (and some sprites because we took the designers out because they were lazy XD) I dedicate myself to trying the Monet (material you) and the custom colors

a, and maybe to put a sound for the keys

(uff I came up with a tremendous idea, bad apple on the keyboard :0)

<item name="keyBorderColorTop">#8AADF4</item>
<item name="keyBorderColorRight">#8AADF4</item>
<item name="keyBorderColorBottom">#8AADF4</item>
<item name="emoji_button_bg">?colorKeyActivated</item>
<item name="emoji_color">#000000</item>
</style>
</resources>
1 change: 1 addition & 0 deletions srcs/juloo.keyboard2/Config.java
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,7 @@ private int getThemeId(Resources res, String theme_name)
case "jungle": return R.style.Jungle;
case "monetlight": return R.style.MonetLight;
case "monetdark": return R.style.MonetDark;
case "pasteldarkblue" : return R.style.PastelDarkBlue;
case "monet":
if ((night_mode & Configuration.UI_MODE_NIGHT_NO) != 0)
return R.style.MonetLight;
Expand Down
Loading