Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default label size #747

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Conversation

bokidori
Copy link
Contributor

PR as per #744

This particular implementation increases default label size by 15%, while existing user set preferences remain unaffected. However, upon testing various default values (1.4, 1.3, 1.25, 1.2, 1.15, 1.1) against different keyboard heights (ranging 27%-35% for portrait mode), I came to the conclusion this might not be the right approach to resolve the issue raised there.

Why? Because the reason I believe we were increasing label size is because we were also reducing the height of the keyboard. With default keyboard height of 35%, label size of 1 is just fine. Only as we reduce the height, label becomes smaller and less intelligible.

However, modification to how the label size scales with regard to keyboard height would require a different approach, with more testing...

Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow reply. Thanks :)

I also think that's not the right approach but this improves the current state and is a simple change. 1.15x seems good in my testing as well. Let's merge!

@Julow Julow merged commit e309b76 into Julow:master Sep 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants