i create a re-desing for themes #487

RetrogisusDEV · 2023-11-02T14:04:14Z

I modified res/themes.xml and srcs/config

no insert charges to res/values/arrays.xml and res/values/string.xml

RetrogisusDEV · 2023-11-02T14:07:08Z

i need more time for add a better theme to Menu config... commit : c428fc7

srcs/juloo.keyboard2/SettingsActivity.java

res/layout/launcher_activity.xml

srcs/juloo.keyboard2/Config.java

srcs/juloo.keyboard2/LauncherActivity.java

res/values/themes.xml

RetrogisusDEV · 2023-11-03T01:19:49Z

Now?

RetrogisusDEV · 2023-11-03T03:02:35Z

I re-created the logo but in xml for adaptative icon 😅

Julow · 2023-11-03T18:37:41Z

I re-created the logo but in xml for adaptative icon 😅

Awesome! I don't see it on the PR, do you intent to open an other PR ?

RetrogisusDEV · 2023-11-03T23:22:24Z

I re-created the logo but in xml for adaptative icon 😅

Awesome! I don't see it on the PR, do you intent to open an other PR ?

:v no, just need a moment and good network

RetrogisusDEV · 2023-11-03T23:38:31Z

1- using Mipmap (just adaptative icon [no need delete drawable icons])
2- using drawable

3- drawable in mipmap (so bad xD)

RetrogisusDEV · 2023-11-06T12:44:25Z

@Julow finished...

Julow · 2023-11-06T19:56:37Z

You have a lot of good ideas ! I want things to be separate so I already merged the launcher icon in 73060bf

RetrogisusDEV · 2023-11-06T21:14:09Z

You have a lot of good ideas ! I want things to be separate so I already merged the launcher icon in 73060bf

ok * cry in tetris *

Julow · 2023-11-06T21:52:39Z

res/values/strings.xml

@@ -60,6 +60,11 @@
  <string name="pref_theme_e_altblack">Alternative Black</string>
  <string name="pref_theme_e_white">White</string>
  <string name="pref_theme_e_epaper">ePaper</string>
+  <string name="pref_theme_e_darkv2">DarkV2</string>
+  <string name="pref_theme_e_lightV2">LightV2</string>


Suggested change

<string name="pref_theme_e_lightV2">LightV2</string>

<string name="pref_theme_e_lightv2">LightV2</string>

Julow · 2023-11-06T22:00:22Z

res/values/themes.xml

@@ -137,4 +137,10 @@
    <item name="emoji_button_bg">#ffffff</item>
    <item name="emoji_color">#000000</item>
  </style>
+
+<style name="Darkv2" parent="@style/BaseTheme"><item name="android:isLightTheme">false</item><item name="colorKeyboard">#ff121212</item><item name="colorKey">#ff434343</item><item name="colorKeyActivated">#ff1a237e</item><item name="colorLabel">#ffffffff</item><item name="colorLabelActivated">#ff000000</item><item name="colorLabelLocked">#ffffffff</item><item name="secondaryLightOffset">-0.2</item><item name="colorSubLabel">#ffaaaaaa</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorBottom">#ff121212</item><item name="emoji_button_bg">?colorKeyActivated</item><item name="emoji_color">#ffffffff</item></style>


Could you explain the point of the darkv2 and lightv2 themes ? I'd prefer to improve the existing themes rather than adding slight variations.

¿Podría explicar el punto de los temas darkv2 y lightv2? Preferiría mejorar los temas existentes en lugar de agregar ligeras variaciones.

Well, I do it separately so that you can visualize them separately, and if you like them, they are changed for the old ones, or leave them aside or eliminate them :v

Julow · 2023-11-06T22:03:25Z

res/values/themes.xml

+<style name="Darkv2" parent="@style/BaseTheme"><item name="android:isLightTheme">false</item><item name="colorKeyboard">#ff121212</item><item name="colorKey">#ff434343</item><item name="colorKeyActivated">#ff1a237e</item><item name="colorLabel">#ffffffff</item><item name="colorLabelActivated">#ff000000</item><item name="colorLabelLocked">#ffffffff</item><item name="secondaryLightOffset">-0.2</item><item name="colorSubLabel">#ffaaaaaa</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorBottom">#ff121212</item><item name="emoji_button_bg">?colorKeyActivated</item><item name="emoji_color">#ffffffff</item></style>
+<style name="Lightv2" parent="@style/BaseTheme"><item name="android:isLightTheme">true</item><item name="colorKeyboard">#fff2f5ff</item><item name="colorKey">#ffffffff</item><item name="colorKeyActivated">#ffc2e7ff</item><item name="colorLabel">#ff222222</item><item name="colorLabelActivated">#ff000000</item><item name="colorLabelLocked">#ffffffff</item><item name="secondaryLightOffset">0.0</item><item name="colorSubLabel">#ff333333</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorLeft">#ffcccccc</item><item name="keyBorderColorTop">#ffeeeeee</item><item name="keyBorderColorRight">#ffcccccc</item><item name="keyBorderColorBottom">#ffaaaaaa</item><item name="emoji_button_bg">?colorKeyActivated</item><item name="emoji_color">#ff000000</item></style>
+<style name="Material" parent="@style/BaseTheme"><item name="android:isLightTheme">true</item><item name="colorKeyboard">#ffeeeeef</item><item name="colorKey">@android:color/white</item><item name="colorKeyActivated">#ff2962ff</item><item name="colorLabel">@android:color/black</item><item name="colorLabelActivated">@android:color/white</item><item name="colorLabelLocked">@android:color/black</item><item name="secondaryLightOffset">0.0</item><item name="colorSubLabel">#ff555566</item><item name="keyBorderRadius">6.0dip</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorBottom">#ff651fff</item><item name="emoji_button_bg">?colorKeyboard</item><item name="emoji_color">?colorLabel</item></style>
+<style name="Desert" parent="@style/BaseTheme"><item name="android:isLightTheme">true</item><item name="colorKeyboard">#ff4db6ac</item><item name="colorKey">#ffe0f2f1</item><item name="colorKeyActivated">#ff00695c</item><item name="colorLabel">#ff000000</item><item name="colorLabelActivated">#ffffffff</item><item name="colorLabelLocked">#ff64ffda</item><item name="secondaryLightOffset">0.0</item><item name="colorSubLabel">#ff004d40</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorLeft">#00f0f0f0</item><item name="keyBorderColorTop">#00f0f0f0</item><item name="keyBorderColorRight">#00eeeeee</item><item name="keyBorderColorBottom">#00eeeeee</item><item name="emoji_button_bg">?colorKeyActivated</item><item name="emoji_color">#ff000000</item></style>


Desert and Jungle looks nice :) But they seem swapped:

Jungle:

Desert:

EXPLANATION plis

Jungle looks yellow and desert looks green. This seems backward.

Jungle looks yellow and desert looks green. This seems backward.

._.XD

Jungle looks yellow and desert looks green. This seems backward.

I'm getting blinder every day

Julow · 2023-11-06T22:09:29Z

res/values/themes.xml

+
+<style name="Darkv2" parent="@style/BaseTheme"><item name="android:isLightTheme">false</item><item name="colorKeyboard">#ff121212</item><item name="colorKey">#ff434343</item><item name="colorKeyActivated">#ff1a237e</item><item name="colorLabel">#ffffffff</item><item name="colorLabelActivated">#ff000000</item><item name="colorLabelLocked">#ffffffff</item><item name="secondaryLightOffset">-0.2</item><item name="colorSubLabel">#ffaaaaaa</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorBottom">#ff121212</item><item name="emoji_button_bg">?colorKeyActivated</item><item name="emoji_color">#ffffffff</item></style>
+<style name="Lightv2" parent="@style/BaseTheme"><item name="android:isLightTheme">true</item><item name="colorKeyboard">#fff2f5ff</item><item name="colorKey">#ffffffff</item><item name="colorKeyActivated">#ffc2e7ff</item><item name="colorLabel">#ff222222</item><item name="colorLabelActivated">#ff000000</item><item name="colorLabelLocked">#ffffffff</item><item name="secondaryLightOffset">0.0</item><item name="colorSubLabel">#ff333333</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorLeft">#ffcccccc</item><item name="keyBorderColorTop">#ffeeeeee</item><item name="keyBorderColorRight">#ffcccccc</item><item name="keyBorderColorBottom">#ffaaaaaa</item><item name="emoji_button_bg">?colorKeyActivated</item><item name="emoji_color">#ff000000</item></style>
+<style name="Material" parent="@style/BaseTheme"><item name="android:isLightTheme">true</item><item name="colorKeyboard">#ffeeeeef</item><item name="colorKey">@android:color/white</item><item name="colorKeyActivated">#ff2962ff</item><item name="colorLabel">@android:color/black</item><item name="colorLabelActivated">@android:color/white</item><item name="colorLabelLocked">@android:color/black</item><item name="secondaryLightOffset">0.0</item><item name="colorSubLabel">#ff555566</item><item name="keyBorderRadius">6.0dip</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorBottom">#ff651fff</item><item name="emoji_button_bg">?colorKeyboard</item><item name="emoji_color">?colorLabel</item></style>


colorKey on the material theme doesn't seem like a material themed keyboard.

colorKey En el tema Material no parece un teclado temático Material.

The colors are taken from a google app... In joke is to use the spaced at [8 V, 2 H] so that it looks good... When I have time I do all that, because I've been working (playing, and I forget)

Julow · 2023-11-06T22:14:05Z

srcs/juloo.keyboard2/SettingsActivity.java

+setTheme(R.style.AppTheme);
+}else{
+setTheme(android.R.style.Theme_Material
+}}


This contains some code duplication and syntax errors.

Julow · 2023-11-06T22:14:58Z

res/drawable/createdirectory

@@ -0,0 +1 @@
+


This file is not needed.

RetrogisusDEV · 2023-11-12T16:00:50Z

I don't like to separate it, it's just to make it a little faster, since I have to create the file and branch on the PC, then edit it on the cell phone, then get the new branch on the cell phone, then pass it to Gadle on the cell phone to test what I do to see if there are problems and then on the PC I pass it to the main one and... (my lore at birth be like: )

Julow · 2023-11-12T16:21:33Z

I prefer to separate the patches as this makes the Git history easier to examine (write changelog, find bugs).

RetrogisusDEV · 2023-11-13T15:21:14Z

I prefer to separate the patches as this makes the Git history easier to examine (write changelog, find bugs).

ok

Julow · 2023-11-16T20:06:44Z

Why did you close this ? I intent to merge the themes and the other things at some point.

Julow · 2023-11-19T10:37:08Z

The Desert and Jungle themes are merged into 80c6f97.

I would really like to see your other good ideas each in a different PR if possible.

Julow · 2023-12-17T19:12:23Z

The "set keyboard" button is merged in df04eae

Julow reviewed Nov 2, 2023

View reviewed changes

Julow reviewed Nov 6, 2023

View reviewed changes

RetrogisusDEV closed this Nov 16, 2023

RetrogisusDEV force-pushed the master branch from dae4eff to b0cf9a5 Compare November 16, 2023 13:03

Julow mentioned this pull request Jan 15, 2024

New setting activity style for newer versions #429

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

i create a re-desing for themes #487

i create a re-desing for themes #487

RetrogisusDEV commented Nov 2, 2023

RetrogisusDEV commented Nov 2, 2023

RetrogisusDEV commented Nov 3, 2023

RetrogisusDEV commented Nov 3, 2023

Julow commented Nov 3, 2023

RetrogisusDEV commented Nov 3, 2023 •

edited

Loading

RetrogisusDEV commented Nov 3, 2023

RetrogisusDEV commented Nov 6, 2023 •

edited

Loading

Julow commented Nov 6, 2023

RetrogisusDEV commented Nov 6, 2023 •

edited

Loading

Julow Nov 6, 2023

Julow Nov 6, 2023

RetrogisusDEV Nov 12, 2023 •

edited

Loading

Julow Nov 6, 2023

RetrogisusDEV Nov 12, 2023

Julow Nov 12, 2023

RetrogisusDEV Nov 13, 2023

RetrogisusDEV Nov 13, 2023

Julow Nov 6, 2023

RetrogisusDEV Nov 12, 2023 •

edited

Loading

Julow Nov 6, 2023

RetrogisusDEV Nov 12, 2023

Julow Nov 6, 2023

RetrogisusDEV Nov 9, 2023

RetrogisusDEV commented Nov 12, 2023 •

edited

Loading

Julow commented Nov 12, 2023

RetrogisusDEV commented Nov 13, 2023

Julow commented Nov 16, 2023

Julow commented Nov 19, 2023

Julow commented Dec 17, 2023

	<string name="pref_theme_e_lightV2">LightV2</string>
	<string name="pref_theme_e_lightv2">LightV2</string>

i create a re-desing for themes #487

i create a re-desing for themes #487

Conversation

RetrogisusDEV commented Nov 2, 2023

RetrogisusDEV commented Nov 2, 2023

RetrogisusDEV commented Nov 3, 2023

RetrogisusDEV commented Nov 3, 2023

Julow commented Nov 3, 2023

RetrogisusDEV commented Nov 3, 2023 • edited Loading

RetrogisusDEV commented Nov 3, 2023

RetrogisusDEV commented Nov 6, 2023 • edited Loading

Julow commented Nov 6, 2023

RetrogisusDEV commented Nov 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RetrogisusDEV Nov 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RetrogisusDEV Nov 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RetrogisusDEV commented Nov 12, 2023 • edited Loading

Julow commented Nov 12, 2023

RetrogisusDEV commented Nov 13, 2023

Julow commented Nov 16, 2023

Julow commented Nov 19, 2023

Julow commented Dec 17, 2023

RetrogisusDEV commented Nov 3, 2023 •

edited

Loading

RetrogisusDEV commented Nov 6, 2023 •

edited

Loading

RetrogisusDEV commented Nov 6, 2023 •

edited

Loading

RetrogisusDEV Nov 12, 2023 •

edited

Loading

RetrogisusDEV Nov 12, 2023 •

edited

Loading

RetrogisusDEV commented Nov 12, 2023 •

edited

Loading