-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i create a re-desing for themes #487
Conversation
i need more time for add a better theme to Menu config... commit : c428fc7 |
Now? |
I re-created the logo but in xml for adaptative icon 😅 |
Awesome! I don't see it on the PR, do you intent to open an other PR ? |
:v no, just need a moment and good network |
@Julow finished... |
You have a lot of good ideas ! I want things to be separate so I already merged the launcher icon in 73060bf |
ok * cry in tetris * |
res/values/strings.xml
Outdated
@@ -60,6 +60,11 @@ | |||
<string name="pref_theme_e_altblack">Alternative Black</string> | |||
<string name="pref_theme_e_white">White</string> | |||
<string name="pref_theme_e_epaper">ePaper</string> | |||
<string name="pref_theme_e_darkv2">DarkV2</string> | |||
<string name="pref_theme_e_lightV2">LightV2</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<string name="pref_theme_e_lightV2">LightV2</string> | |
<string name="pref_theme_e_lightv2">LightV2</string> |
res/values/themes.xml
Outdated
@@ -137,4 +137,10 @@ | |||
<item name="emoji_button_bg">#ffffff</item> | |||
<item name="emoji_color">#000000</item> | |||
</style> | |||
|
|||
<style name="Darkv2" parent="@style/BaseTheme"><item name="android:isLightTheme">false</item><item name="colorKeyboard">#ff121212</item><item name="colorKey">#ff434343</item><item name="colorKeyActivated">#ff1a237e</item><item name="colorLabel">#ffffffff</item><item name="colorLabelActivated">#ff000000</item><item name="colorLabelLocked">#ffffffff</item><item name="secondaryLightOffset">-0.2</item><item name="colorSubLabel">#ffaaaaaa</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorBottom">#ff121212</item><item name="emoji_button_bg">?colorKeyActivated</item><item name="emoji_color">#ffffffff</item></style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain the point of the darkv2 and lightv2 themes ? I'd prefer to improve the existing themes rather than adding slight variations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¿Podría explicar el punto de los temas darkv2 y lightv2? Preferiría mejorar los temas existentes en lugar de agregar ligeras variaciones.
Well, I do it separately so that you can visualize them separately, and if you like them, they are changed for the old ones, or leave them aside or eliminate them :v
res/values/themes.xml
Outdated
<style name="Darkv2" parent="@style/BaseTheme"><item name="android:isLightTheme">false</item><item name="colorKeyboard">#ff121212</item><item name="colorKey">#ff434343</item><item name="colorKeyActivated">#ff1a237e</item><item name="colorLabel">#ffffffff</item><item name="colorLabelActivated">#ff000000</item><item name="colorLabelLocked">#ffffffff</item><item name="secondaryLightOffset">-0.2</item><item name="colorSubLabel">#ffaaaaaa</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorBottom">#ff121212</item><item name="emoji_button_bg">?colorKeyActivated</item><item name="emoji_color">#ffffffff</item></style> | ||
<style name="Lightv2" parent="@style/BaseTheme"><item name="android:isLightTheme">true</item><item name="colorKeyboard">#fff2f5ff</item><item name="colorKey">#ffffffff</item><item name="colorKeyActivated">#ffc2e7ff</item><item name="colorLabel">#ff222222</item><item name="colorLabelActivated">#ff000000</item><item name="colorLabelLocked">#ffffffff</item><item name="secondaryLightOffset">0.0</item><item name="colorSubLabel">#ff333333</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorLeft">#ffcccccc</item><item name="keyBorderColorTop">#ffeeeeee</item><item name="keyBorderColorRight">#ffcccccc</item><item name="keyBorderColorBottom">#ffaaaaaa</item><item name="emoji_button_bg">?colorKeyActivated</item><item name="emoji_color">#ff000000</item></style> | ||
<style name="Material" parent="@style/BaseTheme"><item name="android:isLightTheme">true</item><item name="colorKeyboard">#ffeeeeef</item><item name="colorKey">@android:color/white</item><item name="colorKeyActivated">#ff2962ff</item><item name="colorLabel">@android:color/black</item><item name="colorLabelActivated">@android:color/white</item><item name="colorLabelLocked">@android:color/black</item><item name="secondaryLightOffset">0.0</item><item name="colorSubLabel">#ff555566</item><item name="keyBorderRadius">6.0dip</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorBottom">#ff651fff</item><item name="emoji_button_bg">?colorKeyboard</item><item name="emoji_color">?colorLabel</item></style> | ||
<style name="Desert" parent="@style/BaseTheme"><item name="android:isLightTheme">true</item><item name="colorKeyboard">#ff4db6ac</item><item name="colorKey">#ffe0f2f1</item><item name="colorKeyActivated">#ff00695c</item><item name="colorLabel">#ff000000</item><item name="colorLabelActivated">#ffffffff</item><item name="colorLabelLocked">#ff64ffda</item><item name="secondaryLightOffset">0.0</item><item name="colorSubLabel">#ff004d40</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorLeft">#00f0f0f0</item><item name="keyBorderColorTop">#00f0f0f0</item><item name="keyBorderColorRight">#00eeeeee</item><item name="keyBorderColorBottom">#00eeeeee</item><item name="emoji_button_bg">?colorKeyActivated</item><item name="emoji_color">#ff000000</item></style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EXPLANATION plis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jungle looks yellow and desert looks green. This seems backward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jungle looks yellow and desert looks green. This seems backward.
._.XD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jungle looks yellow and desert looks green. This seems backward.
I'm getting blinder every day
res/values/themes.xml
Outdated
|
||
<style name="Darkv2" parent="@style/BaseTheme"><item name="android:isLightTheme">false</item><item name="colorKeyboard">#ff121212</item><item name="colorKey">#ff434343</item><item name="colorKeyActivated">#ff1a237e</item><item name="colorLabel">#ffffffff</item><item name="colorLabelActivated">#ff000000</item><item name="colorLabelLocked">#ffffffff</item><item name="secondaryLightOffset">-0.2</item><item name="colorSubLabel">#ffaaaaaa</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorBottom">#ff121212</item><item name="emoji_button_bg">?colorKeyActivated</item><item name="emoji_color">#ffffffff</item></style> | ||
<style name="Lightv2" parent="@style/BaseTheme"><item name="android:isLightTheme">true</item><item name="colorKeyboard">#fff2f5ff</item><item name="colorKey">#ffffffff</item><item name="colorKeyActivated">#ffc2e7ff</item><item name="colorLabel">#ff222222</item><item name="colorLabelActivated">#ff000000</item><item name="colorLabelLocked">#ffffffff</item><item name="secondaryLightOffset">0.0</item><item name="colorSubLabel">#ff333333</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorLeft">#ffcccccc</item><item name="keyBorderColorTop">#ffeeeeee</item><item name="keyBorderColorRight">#ffcccccc</item><item name="keyBorderColorBottom">#ffaaaaaa</item><item name="emoji_button_bg">?colorKeyActivated</item><item name="emoji_color">#ff000000</item></style> | ||
<style name="Material" parent="@style/BaseTheme"><item name="android:isLightTheme">true</item><item name="colorKeyboard">#ffeeeeef</item><item name="colorKey">@android:color/white</item><item name="colorKeyActivated">#ff2962ff</item><item name="colorLabel">@android:color/black</item><item name="colorLabelActivated">@android:color/white</item><item name="colorLabelLocked">@android:color/black</item><item name="secondaryLightOffset">0.0</item><item name="colorSubLabel">#ff555566</item><item name="keyBorderRadius">6.0dip</item><item name="keyBorderWidth">0.0dip</item><item name="keyBorderWidthActivated">0.0dip</item><item name="keyBorderColorBottom">#ff651fff</item><item name="emoji_button_bg">?colorKeyboard</item><item name="emoji_color">?colorLabel</item></style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colorKey
on the material theme doesn't seem like a material themed keyboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colorKey
En el tema Material no parece un teclado temático Material.
The colors are taken from a google app... In joke is to use the spaced at [8 V, 2 H] so that it looks good... When I have time I do all that, because I've been working (playing, and I forget)
setTheme(R.style.AppTheme); | ||
}else{ | ||
setTheme(android.R.style.Theme_Material | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This contains some code duplication and syntax errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:v
res/drawable/createdirectory
Outdated
@@ -0,0 +1 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No...
I don't like to separate it, it's just to make it a little faster, since I have to create the file and branch on the PC, then edit it on the cell phone, then get the new branch on the cell phone, then pass it to Gadle on the cell phone to test what I do to see if there are problems and then on the PC I pass it to the main one and... (my lore at birth be like: ) |
I prefer to separate the patches as this makes the Git history easier to examine (write changelog, find bugs). |
ok |
dae4eff
to
b0cf9a5
Compare
Why did you close this ? I intent to merge the themes and the other things at some point. |
The Desert and Jungle themes are merged into 80c6f97. I would really like to see your other good ideas each in a different PR if possible. |
The "set keyboard" button is merged in df04eae |
I modified res/themes.xml and srcs/config
no insert charges to res/values/arrays.xml and res/values/string.xml