Skip to content

Commit

Permalink
CI: Improve layout and store description checks (#565)
Browse files Browse the repository at this point in the history
* CI: Run 'check_layout.py'

Ensures that 'check_layout.output' is not outdated.
Also, update it.

* CI: Check new store descriptions

When a store description is added, 'python3 sync_translations.py' leaves
an untracked file that is not checked.

This makes sure that untracked store descriptions are noticed in CI.
  • Loading branch information
Julow authored Feb 18, 2024
1 parent f2f6ef0 commit dac702a
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 10 deletions.
17 changes: 12 additions & 5 deletions .github/workflows/check-layouts.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,26 @@
name: Check layouts

# Runs 'gen_layouts.py' and checks that the generated file were uptodate.
# This doesn't run 'check_layout.py'.

on:
workflow_dispatch:
push:
pull_request:

jobs:
check-layouts:
gen-layouts:
name: Generated files
runs-on: ubuntu-latest
steps:
- name: Checkout repo
uses: actions/checkout@v4
- run: python3 gen_layouts.py
- name: Check that the generated layouts.xml is uptodate, run python3 gen_layouts.py otherwise
- name: "Check that the generated 'layouts.xml' is uptodate, otherwise run 'python3 gen_layouts.py'"
run: git diff --exit-code
check-layouts:
name: check_layout.output
runs-on: ubuntu-latest
steps:
- name: Checkout repo
uses: actions/checkout@v4
- run: python3 check_layout.py
- name: "Check that the generated 'check_layout.output' is uptodate, otherwise run 'python3 check_layout.py'"
run: git diff --exit-code
4 changes: 2 additions & 2 deletions .github/workflows/check-translations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ jobs:
- name: Checkout repo
uses: actions/checkout@v4
- run: python3 sync_translations.py
- name: Check that strings files are uptodate, run python3 sync_translations.py otherwise
run: git diff --exit-code
- name: "Check that strings files are uptodate, otherwise run 'python3 sync_translations.py'"
run: git add -N . && git diff --exit-code
5 changes: 2 additions & 3 deletions check_layout.output
Original file line number Diff line number Diff line change
Expand Up @@ -65,16 +65,15 @@ Layout doesn't define some important keys, missing: f11_placeholder, f12_placeho
1 warnings
# latn_bone
Layout includes some ASCII punctuation but not all, missing: $
Layout redefines the bottom row but some important keys are missing, missing: compose, cursor_left, cursor_right, loc end, loc home, loc page_down, loc page_up, loc switch_greekmath, loc voice_typing, switch_backward
Layout redefines the bottom row but some important keys are missing, missing: cursor_left, cursor_right, loc compose, loc end, loc home, loc page_down, loc page_up, loc switch_greekmath, loc voice_typing, switch_backward
2 warnings
# latn_colemak
Some keys contain whitespaces, unexpected: ́
1 warnings
# latn_dvorak
0 warnings
# latn_neo2
Layout redefines the bottom row but some important keys are missing, missing: compose, loc end, loc home, loc page_down, loc page_up
1 warnings
0 warnings
# latn_qwerty_br
0 warnings
# latn_qwerty_cz
Expand Down
6 changes: 6 additions & 0 deletions metadata/android/uk/full_description.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Головна особливість полягає в тому, що ви можете вводити більше символів, проводячи клавіші до кутів.

Ця програма спочатку була розроблена для програмістів, які використовують Termux.
Тепер ідеально підходить для щоденного використання.

Ця програма не містить реклами, не надсилає жодних мережевих запитів і має відкритий код.
1 change: 1 addition & 0 deletions metadata/android/uk/short_description.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Легка та конфіденційна віртуальна клавіатура для Android.

0 comments on commit dac702a

Please sign in to comment.