Skip to content

Commit

Permalink
Circle and round trip gestures
Browse files Browse the repository at this point in the history
This implements clockwise/anticlockwise circle and round trip gestures
inspired by Messagease.

The circle gestures start after a small threshold to avoid making the
regular swipe too hard to aim.

The gestures do:

- clockwise circle: Shift variant of the center symbol
- anticlockwise circle: Fn variant of the center symbol
- round trip: Fn variant of the targetted side symbol

The Gesture class now keep track of what the pointer is doing while it
moves on a key. It replaces the 'selected_direction' integer.
  • Loading branch information
Julow committed May 23, 2024
1 parent 96fc400 commit 8021a62
Show file tree
Hide file tree
Showing 3 changed files with 210 additions and 38 deletions.
126 changes: 126 additions & 0 deletions srcs/juloo.keyboard2/Gesture.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
package juloo.keyboard2;

public final class Gesture
{
/** The pointer direction that caused the last state change.
Integer from 0 to 15 (included). */
int current_dir;

State state;

public Gesture(int starting_direction)
{
current_dir = starting_direction;
state = State.Swiped;
}

enum State
{
Cancelled,
Swiped,
Rotating_clockwise,
Rotating_anticlockwise,
Ended_swipe,
Ended_center,
Ended_clockwise,
Ended_anticlockwise
}

/** Angle to travel before a rotation gesture starts. A threshold too low
would be too easy to reach while doing back and forth gestures, as the
quadrants are very small. In the same unit as [current_dir] */
static final int ROTATION_THRESHOLD = 2;

/** Modify the key depending on the current gesture. Return [null] if the
gesture is invalid or if [KeyModifier] returned [null]. */
public KeyValue modify_key(KeyValue selected_val, KeyboardData.Key key)
{
switch (state)
{
case Cancelled:
return null;
case Swiped:
case Ended_swipe:
return selected_val;
case Ended_center:
return KeyModifier.modify_round_trip(selected_val);
case Rotating_clockwise:
case Ended_clockwise:
return KeyModifier.modify_circle(key.keys[0], true);
case Rotating_anticlockwise:
case Ended_anticlockwise:
return KeyModifier.modify_circle(key.keys[0], false);
}
return null; // Unreachable
}

public boolean is_in_progress()
{
switch (state)
{
case Swiped:
case Rotating_clockwise:
case Rotating_anticlockwise:
return true;
}
return false;
}

/** The pointer changed direction. Return [true] if the gesture changed state. */
public boolean changed_direction(int direction)
{
int d = dir_diff(current_dir, direction);
boolean clockwise = d > 0;
switch (state)
{
case Swiped:
if (Math.abs(d) < ROTATION_THRESHOLD)
return false;
// Start a rotation
state = (clockwise) ?
State.Rotating_clockwise : State.Rotating_anticlockwise;
current_dir = direction;
return true;
// Check that rotation is not reversing
case Rotating_clockwise:
case Rotating_anticlockwise:
current_dir = direction;
if ((state == State.Rotating_clockwise) == clockwise)
return false;
state = State.Cancelled;
return true;
}
return false;
}

public void moved_to_center()
{
switch (state)
{
case Swiped: state = State.Ended_center; break;
case Rotating_clockwise: state = State.Ended_clockwise; break;
case Rotating_anticlockwise: state = State.Ended_anticlockwise; break;
}
}

public void pointer_up()
{
switch (state)
{
case Swiped: state = State.Ended_swipe; break;
case Rotating_clockwise: state = State.Ended_clockwise; break;
case Rotating_anticlockwise: state = State.Ended_anticlockwise; break;
}
}

static int dir_diff(int d1, int d2)
{
final int n = 16;
// Shortest-path in modulo arithmetic
if (d1 == d2)
return 0;
int left = (d1 - d2 + n) % n;
int right = (d2 - d1 + n) % n;
return (left < right) ? -left : right;
}
}
20 changes: 16 additions & 4 deletions srcs/juloo.keyboard2/KeyModifier.java
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,19 @@ public static KeyValue modify_long_press(KeyValue k)
return k;
}

public static KeyValue modify_round_trip(KeyValue k)
{
return apply_fn(k);
}

public static KeyValue modify_circle(KeyValue k, boolean clockwise)
{
if (clockwise)
return apply_shift(k);
else
return apply_fn(k);
}

public static Map_char modify_numpad_script(String numpad_script)
{
if (numpad_script == null)
Expand All @@ -139,11 +152,10 @@ private static KeyValue apply_map_char(KeyValue k, Map_char map)
case Char:
char kc = k.getChar();
String modified = map.apply(kc);
if (modified == null)
return k;
return KeyValue.makeStringKey(modified, k.getFlags());
default: return k;
if (modified != null)
return KeyValue.makeStringKey(modified, k.getFlags());
}
return k;
}

private static KeyValue apply_shift(KeyValue k)
Expand Down
102 changes: 68 additions & 34 deletions srcs/juloo.keyboard2/Pointers.java
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,13 @@ public void onTouchUp(int pointerId)
return;
}
stopKeyRepeat(ptr);
KeyValue ptr_value = ptr.value;
if (ptr.gesture != null && ptr.gesture.is_in_progress())
{
// A gesture was in progress
ptr.gesture.pointer_up();
ptr_value = ptr.gesture.modify_key(ptr.value, ptr.key);
}
Pointer latched = getLatched(ptr);
if (latched != null) // Already latched
{
Expand All @@ -152,7 +159,7 @@ public void onTouchUp(int pointerId)
else // Otherwise, unlatch
{
removePtr(latched);
_handler.onPointerUp(ptr.value, ptr.modifiers);
_handler.onPointerUp(ptr_value, ptr.modifiers);
}
}
else if ((ptr.flags & FLAG_P_LATCHABLE) != 0)
Expand All @@ -168,7 +175,7 @@ else if ((ptr.flags & FLAG_P_LATCHABLE) != 0)
{
clearLatched();
removePtr(ptr);
_handler.onPointerUp(ptr.value, ptr.modifiers);
_handler.onPointerUp(ptr_value, ptr.modifiers);
}
}

Expand Down Expand Up @@ -217,18 +224,15 @@ KeyValue getKeyAtDirection(KeyboardData.Key k, int direction)
return k.keys[DIRECTION_TO_INDEX[direction]];
}

/*
* Get the KeyValue at the given direction. In case of swipe (direction !=
* null), get the nearest KeyValue that is not key0.
* Take care of applying [_handler.onPointerSwipe] to the selected key, this
* must be done at the same time to be sure to treat removed keys correctly.
* Return [null] if no key could be found in the given direction or if the
* selected key didn't change.
/**
* Get the key nearest to [direction] that is not key0. Take care
* of applying [_handler.modifyKey] to the selected key in the same
* operation to be sure to treat removed keys correctly.
* Return [null] if no key could be found in the given direction or
* if the selected key didn't change.
*/
private KeyValue getNearestKeyAtDirection(Pointer ptr, Integer direction)
private KeyValue getNearestKeyAtDirection(Pointer ptr, int direction)
{
if (direction == null)
return _handler.modifyKey(ptr.key.keys[0], ptr.modifiers);
KeyValue k;
// [i] is [0, -1, 1, -2, 2, ...]
for (int i = 0; i > -4; i = (~i>>31) - i)
Expand Down Expand Up @@ -261,37 +265,59 @@ public void onTouchMove(float x, float y, int pointerId)
float dy = y - ptr.downY;

float dist = Math.abs(dx) + Math.abs(dy);
Integer direction;
if (dist < _config.swipe_dist_px)
{
direction = null;
// Pointer is still on the center.
if (ptr.gesture == null || !ptr.gesture.is_in_progress())
return;
// Gesture ended
ptr.gesture.moved_to_center();
ptr.value = ptr.gesture.modify_key(ptr.value, ptr.key);
ptr.flags = pointer_flags_of_kv(ptr.value);

}
else
{
{ // Pointer is on a quadrant.
// See [getKeyAtDirection()] for the meaning. The starting point on the
// circle is the top direction.
double a = Math.atan2(dy, dx) + Math.PI;
// a is between 0 and 2pi, 0 is pointing to the left
// add 12 to align 0 to the top
direction = ((int)(a * 8 / Math.PI) + 12) % 16;
}
int direction = ((int)(a * 8 / Math.PI) + 12) % 16;
if (ptr.gesture == null)
{ // Gesture starts

ptr.gesture = new Gesture(direction);
KeyValue new_value = getNearestKeyAtDirection(ptr, direction);
if (new_value != null)
{ // Pointer is swiping into a side key.

ptr.value = new_value;
ptr.flags = pointer_flags_of_kv(new_value);
// Sliding mode is entered when key5 or key6 is down on a slider key.
if (ptr.key.slider &&
(new_value.equals(ptr.key.getKeyValue(5))
|| new_value.equals(ptr.key.getKeyValue(6))))
{
startSliding(ptr, x);
}
_handler.onPointerDown(new_value, true);
}

if (direction != ptr.selected_direction)
{
ptr.selected_direction = direction;
KeyValue newValue = getNearestKeyAtDirection(ptr, direction);
if (newValue != null && !newValue.equals(ptr.value))
{
ptr.value = newValue;
ptr.flags = pointer_flags_of_kv(newValue);
// Sliding mode is entered when key5 or key6 is down on a slider key.
if (ptr.key.slider &&
(newValue.equals(ptr.key.getKeyValue(5))
|| newValue.equals(ptr.key.getKeyValue(6))))
}
else if (ptr.gesture.changed_direction(direction))
{ // Gesture changed state
if (!ptr.gesture.is_in_progress())
{ // Gesture ended
stopKeyRepeat(ptr);
_handler.onPointerFlagsChanged(true);
}
else
{
startSliding(ptr, x);
ptr.value = ptr.gesture.modify_key(ptr.value, ptr.key);
restartKeyRepeat(ptr);
ptr.flags = 0; // Special behaviors are ignored during a gesture.
}
_handler.onPointerDown(newValue, true);
}
}
}
Expand Down Expand Up @@ -395,6 +421,12 @@ private void stopKeyRepeat(Pointer ptr)
}
}

private void restartKeyRepeat(Pointer ptr)
{
stopKeyRepeat(ptr);
startKeyRepeat(ptr);
}

/** A pointer is repeating. Returns [true] if repeat should continue. */
private boolean handleKeyRepeat(Pointer ptr)
{
Expand Down Expand Up @@ -447,14 +479,16 @@ static int pointer_flags_of_kv(KeyValue kv)
return flags;
}

// Pointers

private static final class Pointer
{
/** -1 when latched. */
public int pointerId;
/** The Key pressed by this Pointer */
public final KeyboardData.Key key;
/** Current direction. [null] means not swiping. */
public Integer selected_direction;
/** Gesture state, see [Gesture]. [null] means the pointer has not moved out of the center region. */
public Gesture gesture;
/** Selected value with [modifiers] applied. */
public KeyValue value;
public float downX;
Expand All @@ -472,7 +506,7 @@ public Pointer(int p, KeyboardData.Key k, KeyValue v, float x, float y, Modifier
{
pointerId = p;
key = k;
selected_direction = null;
gesture = null;
value = v;
downX = x;
downY = y;
Expand Down

0 comments on commit 8021a62

Please sign in to comment.