Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARP module #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ARP module #15

wants to merge 2 commits into from

Conversation

lachrimae
Copy link

I'd like to parse ARP packets for Ethernet+IPv4. Might you be interested in merging this if I complete the implementation?

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #15 (cab1b5b) into master (1d2be79) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          45       45           
  Lines       16320    16320           
=======================================
  Hits        16271    16271           
  Misses         49       49           
Impacted Files Coverage Δ
src/link/mod.rs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2be79...cab1b5b. Read the comment docs.

@JulianSchmid JulianSchmid changed the title add ARP module Add ARP module Nov 28, 2021
@JulianSchmid JulianSchmid added this to the v0.11 milestone Dec 24, 2021
@JulianSchmid JulianSchmid modified the milestones: v0.11, v0.12 Jul 2, 2022
@ravenexp
Copy link

ravenexp commented Jul 8, 2022

Hi! I'm interested in using etherparse for parsing and building ARP packets.

My current implementation uses Ethernet2Header and a hand-coded ARP parser/builder.
This PR contains a higher quality implementation that I'd like to adopt.

I somewhat disagree on the implementation approach though: there is no such thing as "ARP header" according to RFC 826. ARP defines fixed-length Ethernet packets that have a very simple structure. Breaking it down further into "ARP header" and "ARP payload" seems artificial to me.

Should I try to submit an independent PR or are you rather interested in merging the current one?

@JulianSchmid JulianSchmid modified the milestones: v0.12, v0.13 Jul 24, 2022
@lachrimae
Copy link
Author

@ravenexp I am pretty happy for you to submit your own version of the ARP module with the improvements you have in mind. I haven't heard back from the maintainer on this thread so I'm not sure what they think.

@JulianSchmid JulianSchmid modified the milestones: v0.13, v0.15 Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants