Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TZJData artifact constants #3

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Create TZJData artifact constants #3

merged 1 commit into from
Jul 30, 2023

Conversation

omus
Copy link
Member

@omus omus commented Jul 30, 2023

Adds the ARTIFACT_DIR and TZDATA_VERSION contants to the TZJData.jl package. Unfortunately, we have a chicken and egg situation: we do not want to create a tag/release without these changes but these changes cause the TZJData package to fail to load without having the tag/release containing the necessary artifacts.

For now, we'll just accept that the tests will fail with this PR and generate the artifacts we need as a follow up to this PR.

@omus omus merged commit b6fbf44 into main Jul 30, 2023
0 of 3 checks passed
@omus omus deleted the cv/constants branch July 30, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant