Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write paper for JOSS #7

Merged
merged 13 commits into from
Dec 7, 2019
Merged

Write paper for JOSS #7

merged 13 commits into from
Dec 7, 2019

Conversation

oxinabox
Copy link
Member

This is blocked by #5 as it says that that is done.

@codecov-io
Copy link

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files           5        5           
  Lines          94       94           
=======================================
  Hits           90       90           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882f439...6086657. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Aug 31, 2018

Codecov Report

Merging #7 into master will decrease coverage by 1.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   95.74%   94.41%   -1.34%     
==========================================
  Files           5       10       +5     
  Lines          94      555     +461     
==========================================
+ Hits           90      524     +434     
- Misses          4       31      +27
Impacted Files Coverage Δ
src/words/sedbased.jl 100% <0%> (ø) ⬆️
src/words/tweet_tokenizer.jl 91.15% <0%> (ø)
src/words/TokTok.jl 98.43% <0%> (ø)
src/words/fast.jl 98.14% <0%> (ø)
src/words/reversible_tokenize.jl 100% <0%> (ø)
src/words/nltk_word.jl 100% <0%> (ø)
src/words/simple.jl 100% <0%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882f439...53e5d1c. Read the comment docs.

@Ayushk4
Copy link
Member

Ayushk4 commented Jun 30, 2019

Can I update this with information about TokenBuffer and its lexers to create custom tokenizers? And also other tokenizers - Reversible Tokenizer, Twitter Tokenizers?

@oxinabox
Copy link
Member Author

yes, please do, and add self as a coauther, and @MikeInnes and @aquatiko too.

@oxinabox
Copy link
Member Author

@MikeInnes @aquatiko @Ayushk4
as you are all listed as authors, can you review this,
and if happy indicate so via github apprroval?

Then we can submit this

Add plot comparing speeds of tokenizers to JOSS paper.
@oxinabox
Copy link
Member Author

oxinabox commented Dec 1, 2019

Sorry I forgot to action this.
Last thing is I think should swap the author order and put @Ayushk4 as first author,
as they have done much more on this recently than me.

If I don't hear any objections, I will do this and then will merge and submit

@oxinabox oxinabox merged commit 3fedb56 into master Dec 7, 2019
@oxinabox
Copy link
Member Author

oxinabox commented Dec 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants