Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single Array in Transform3D, parameterize Transform3D on array type #215

Merged
merged 2 commits into from
Apr 25, 2017

Conversation

tkoolen
Copy link
Collaborator

@tkoolen tkoolen commented Apr 24, 2017

Towards #212, #207.

Other changes required by this move:

  • add rotation and translation functions to replace accessing members of Transform3D
  • change signatures of eye and rand methods.

A bit faster on 0.6, as expected.

@codecov
Copy link

codecov bot commented Apr 24, 2017

Codecov Report

Merging #215 into master will decrease coverage by 0.01%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   94.85%   94.83%   -0.02%     
==========================================
  Files          18       18              
  Lines        2041     2053      +12     
==========================================
+ Hits         1936     1947      +11     
- Misses        105      106       +1
Impacted Files Coverage Δ
src/joint.jl 93.75% <ø> (ø) ⬆️
src/mechanism.jl 90.32% <ø> (ø) ⬆️
src/joint_types.jl 94.28% <100%> (-0.07%) ⬇️
src/mechanism_state.jl 98.1% <100%> (ø) ⬆️
src/rigid_body.jl 90.9% <100%> (ø) ⬆️
src/parse_urdf.jl 93.67% <100%> (ø) ⬆️
src/mechanism_manipulation.jl 98.07% <100%> (ø) ⬆️
src/frames.jl 92.22% <94.44%> (+1.19%) ⬆️
src/spatial.jl 92.95% <95.23%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e9c78...c0af877. Read the comment docs.

@tkoolen tkoolen merged commit 94bc9da into master Apr 25, 2017
@tkoolen tkoolen deleted the transform-array-param branch April 25, 2017 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant