Cleanup #4
Merged
Cleanup #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
==========================================
+ Coverage 88.16% 90.68% +2.51%
==========================================
Files 4 4
Lines 169 161 -8
==========================================
- Hits 149 146 -3
+ Misses 20 15 -5
Continue to review full report at Codecov.
|
rdeits
commented
Feb 28, 2018
| @@ -1,24 +1,3 @@ | |||
| """ | |||
| Interpolations.jl requires that one(::Type{T}) be defined for any data | |||
There was a problem hiding this comment.
It looks like Interpolations.jl has fixed this issue, so this entire type is no longer required. Hooray!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanups based on @tkoolen's feedback from #3