Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix plot size in png - rework docs #269

Merged
merged 1 commit into from
Jun 18, 2022
Merged

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Jun 18, 2022

  • fix incorrect plot size when exporting to png (buggy polarplot);
  • cache font for speeding up png_image & savefig;
  • add banner for pending Term 1.0.

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2022

Codecov Report

Merging #269 (665c3f2) into master (ecef83a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #269   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         1684      1686    +2     
=========================================
+ Hits          1684      1686    +2     
Impacted Files Coverage Δ
src/canvas/dotcanvas.jl 100.00% <ø> (ø)
src/interface/polarplot.jl 100.00% <ø> (ø)
src/canvas/braillecanvas.jl 100.00% <100.00%> (ø)
src/plot.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecef83a...665c3f2. Read the comment docs.

@t-bltg t-bltg merged commit 39f1c67 into JuliaPlots:master Jun 18, 2022
@t-bltg t-bltg deleted the banner branch June 18, 2022 18:46
@t-bltg t-bltg added the bug label Jun 20, 2022
@t-bltg
Copy link
Member Author

t-bltg commented Jun 22, 2022

We need to cache the fonts in order to bypass JuliaGraphics/FreeTypeAbstraction.jl#67.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants