Fix EOF detection for p4est on Windows #3106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes cburstedde/p4est#115 until a new release of the upstream library with the fix is available.
It's a bug that can only appear on Windows due to
toupper(EOF)
being undefined behavior, whereas on Linux/macOS/BSD,toupper(EOF) == EOF
.By moving the check for
EOF
before the conversiontoupper
, the relevant code section works as intended and independent of the platform.