Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for FreeBSD AArch64 support #1342

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

ararslan
Copy link
Member

Same as is done for macOS AArch64. Also mention FreeBSD AArch64 in the documentation for what's built by default (ref JuliaPackaging/BinaryBuilderBase.jl#387, JuliaPackaging/Yggdrasil#9220).

@giordano
Copy link
Member

giordano commented Sep 7, 2024

After the PR in BBB is merged, please bump the BBB requirement here to v1.31 and delete the manifest (it's becoming more problematic than anything at some point)

@ararslan ararslan force-pushed the aa/no-aarch64-freebsd-on-julia-1.5 branch from 72814b8 to b534199 Compare September 7, 2024 20:38
@ararslan
Copy link
Member Author

ararslan commented Sep 7, 2024

Done. I've also bumped the minor version of the package per our discussion in Slack. The commits are logically separated but feel free to squash if you prefer.

Changes:
- Include FreeBSD AArch64 in minimum Julia compat check as is done for
  macOS AArch64.
- Mention FreeBSD AArch64 in the documentation for what's built by
  default.
- Avoid installing the Rust compiler shards on FreeBSD AArch64 because
  they don't exist (yet?!?!).
As of this version, the package will error upon loading if used with
Julia > 1.7. Previously it could be loaded but didn't work properly with
later Julia versions. To be safe, we're making this a breaking release.
It should be a largely user-invisible change though, as BinaryBuilder is
generally not used as a package dependency.
@ararslan ararslan force-pushed the aa/no-aarch64-freebsd-on-julia-1.5 branch from 90705aa to 48fc5b8 Compare September 8, 2024 00:28
@ararslan ararslan changed the title Include FreeBSD AArch64 in minimum Julia compat check Updates for FreeBSD AArch64 support Sep 8, 2024
@giordano giordano merged commit 49f57bf into master Sep 8, 2024
7 of 10 checks passed
@giordano giordano deleted the aa/no-aarch64-freebsd-on-julia-1.5 branch September 8, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants