Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added outputs for the verbose kwarg #16

Merged
merged 4 commits into from
Jun 22, 2024
Merged

Conversation

dylan-asmar
Copy link
Member

I did not include a version bump with this PR, but I would recommend bumping the version if merged.

Closes #1

@WhiffleFish I wasn't 100% sure if I implemented # Beliefs correctly. I am using sum(.!tree.b_pruned) to determine the number of beliefs. If this is correct, then it appears NativeSARSOP is using more beliefs than SARSOP which is slowing it down a bit when you compare it on larger problems like TagPOMDPProblem.

Copy link
Member

@WhiffleFish WhiffleFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this PR, Dylan. I would say that you've implemented # Beliefs correctly. You are correct that NativeSARSOP generally expands more beliefs than SARSOP. This is likely due to #3, where SARSOP has the ability to cut tree traversals short with a better binned belief value estimate.

src/solver.jl Outdated Show resolved Hide resolved
@WhiffleFish WhiffleFish merged commit da75251 into main Jun 22, 2024
4 checks passed
@dylan-asmar dylan-asmar deleted the add_versbose_option branch June 22, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verbose kwarg doesn't do anything
2 participants