Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of OCIM2_48L (updated NCDataset syntax) #98

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

briochemc
Copy link
Member

fix #97

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.72%. Comparing base (fe509e7) to head (274e852).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   48.75%   52.72%   +3.97%     
==========================================
  Files          23       23              
  Lines        1081     1081              
==========================================
+ Hits          527      570      +43     
+ Misses        554      511      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briochemc briochemc merged commit eb5e3cb into master Jun 25, 2024
8 of 16 checks passed
@briochemc
Copy link
Member Author

Hi @JianghuiDu! This PR should fix the bug with OCIM2-48L. I am tagging a new version (v0.13.4) and releasing right away, so please allow for a couple hours before simply updating your AIBECS package and you should be good to go. I've also swapped in the OCIM2 48L circulation for the ideal age tutorial, so you should be able to directly use that: https://juliaocean.github.io/AIBECS.jl/previews/PR98/tutorials/1_ideal_age/.

@briochemc briochemc deleted the issue97 branch June 25, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot load OCIM2_48L?
1 participant