remove GenericSVD and GenericSchur as dependencies #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to type piracy, these packages cause problems with precompilation and don't play nice with GenericLinearAlgebra (see discussion in JuliaLinearAlgebra/GenericLinearAlgebra.jl#71). Additionally, GenericSVD has now been deprecated (JuliaLinearAlgebra/GenericSVD.jl#30).
|
I've added GenericSchur and GenericLinearAlgebra as test dependencies |
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
- Coverage 45.87% 45.86% -0.02%
==========================================
Files 63 63
Lines 3202 3203 +1
==========================================
Hits 1469 1469
- Misses 1733 1734 +1
Continue to review full report at Codecov.
|
|
@simonbyrne Apologies for the delay -- I was indesposed. |
|
@JeffreySarnoff did you mean to close without merging? |
|
no -- restarting this |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to type piracy, these packages cause problems with precompilation and don't play nice with GenericLinearAlgebra (see discussion in JuliaLinearAlgebra/GenericLinearAlgebra.jl#71). Additionally, GenericSVD has now been deprecated (JuliaLinearAlgebra/GenericSVD.jl#30).