Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chain rules for FFT plans via AdjointPlans #67
Chain rules for FFT plans via AdjointPlans #67
Changes from 22 commits
ad71816
c91ad50
061eef9
497ff4d
5d5c06c
ef84edf
d7ff394
aa8e575
9d99886
ac7c78c
8474141
769c090
3ed83df
552d49f
1e9ece2
8ddfa97
87758c8
09b8b38
d967aa2
2a423e2
eedba14
25bb86b
2a2d685
fe3b06a
266c88f
403ce47
e137ae3
e601347
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need
real
here, in contrast toRealInverseProjectionStyle
below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's right, since we should only expect an
rfft
plan to operate on real arrays. I've addedT<:Real
to make this clear.Also, regarding the use of
real(T)
for theRealInverseProjectionStyle
: I could possibly just matchAdjointPlan{Complex{T}}
and then useT
instead ofreal(T)
, since we probably should expect anirfft
to operate on complex arrays. (The test plans were actually gettingT
wrong, i.e.T<:Real
for the inverse of a rfft, but I've fixed that in eedba14). However,real(T)
seems a little safer in case someone ever wants to write a specializedirfft
plan that accepts only real inputs.