allocate_result IsExplicitDecorator (#123)

* allocate_result IsExplicitDecorator * add test and bump version
JuliaManifolds · Aug 5, 2022 · a2cb5df · a2cb5df · kellertuer · Aug 5, 2022
1 parent dad56f8
commit a2cb5df
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "ManifoldsBase"
 uuid = "3362f125-f0bb-47a3-aa74-596ffd7ef2fb"
 authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
-version = "0.13.17"
+version = "0.13.18"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

diff --git a/src/decorator_trait.jl b/src/decorator_trait.jl
@@ -132,6 +132,14 @@ function allocate_result(
     T = allocate_result_type(get_embedding(M, x[1]), f, x)
     return allocate(M, x[1], T, representation_size(M))
 end
+@inline function allocate_result(
+    ::TraitList{IsExplicitDecorator},
+    M::AbstractDecoratorManifold,
+    f,
+    x...,
+)
+    return allocate_result(decorated_manifold(M), f, x...)
+end
 
 
 # Introduce Deco Trait | automatic foward | fallback

diff --git a/test/embedded_manifold.jl b/test/embedded_manifold.jl
@@ -418,5 +418,6 @@ ManifoldsBase.decorated_manifold(::FallbackManifold) = DefaultManifold(3)
         # test the explicit fallback to DefaultManifold(3)
         @test inner(M, [1, 0, 0], [1, 2, 3], [0, 1, 0]) == 2
         @test is_point(M, [1, 0, 0])
+        @test ManifoldsBase.allocate_result(M, exp, [1.0, 0.0, 2.0]) isa Vector
     end
 end