Merge pull request #47 from JuliaManifolds/mbaran/fix-fill-Julia-1.0

fixing mid_point on Julia 1.0

Project.toml

@@ -1,7 +1,7 @@
 name = "ManifoldsBase"
 uuid = "3362f125-f0bb-47a3-aa74-596ffd7ef2fb"
 authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
-version = "0.9.0"
+version = "0.9.1"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/ManifoldsBase.jl

@@ -565,8 +565,19 @@ Saves the result in `q`.
 """
 function mid_point!(M::Manifold, q, p1, p2)
     X = log(M, p1, p2)
-    X /= 2
-    return exp!(M, q, p1, X)
+    return exp!(M, q, p1, X / 2)
+end
+
+@static if VERSION <= v"1.1"
+    function mid_point!(
+        M::Manifold,
+        q::AbstractArray{T1,0},
+        p1::AbstractArray{T2,0},
+        p2::AbstractArray{T3,0},
+    ) where {T1,T2,T3}
+        X = log(M, p1, p2)
+        return exp!(M, q, p1, fill(X / 2))
+    end
 end
 
 """

test/default_manifold.jl

@@ -279,4 +279,11 @@ Base.size(x::MatrixVectorTransport) = (size(x.m, 2),)
             end
         end
     end
+
+    @testset "mid_point on 0-index arrays" begin
+        M = ManifoldsBase.DefaultManifold(1)
+        p1 = fill(0.0)
+        p2 = fill(1.0)
+        @test isapprox(M, fill(0.5), mid_point(M, p1, p2))
+    end
 end

test/runtests.jl

@@ -2,9 +2,11 @@ using Test
 using ManifoldsBase
 @testset "ManifoldsBase" begin
 
-    num_ambiguities = length(Test.detect_ambiguities(ManifoldsBase))
-    #num_ambiguities > 0 && @warn "The number of ambiguities in ManifoldsBase is $(num_ambiguities)."
-    @test num_ambiguities == 0
+    if VERSION >= v"1.1"
+        num_ambiguities = length(Test.detect_ambiguities(ManifoldsBase))
+        #num_ambiguities > 0 && @warn "The number of ambiguities in ManifoldsBase is $(num_ambiguities)."
+        @test num_ambiguities == 0
+    end
     include("allocation.jl")
     include("numbers.jl")
     include("bases.jl")