Fix zero argument result allocation for nested power manifold (#95)

* Fix zero argument result allocation for nested power manifold

* complex allocation

* disambiguate

* test & fix

Project.toml

@@ -1,7 +1,7 @@
 name = "ManifoldsBase"
 uuid = "3362f125-f0bb-47a3-aa74-596ffd7ef2fb"
 authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
-version = "0.12.12"
+version = "0.12.13"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/PowerManifold.jl

@@ -200,7 +200,7 @@ function Base.:^(
 end
 
 function allocate_result(M::PowerManifoldNested, f, x...)
-    if representation_size(M.manifold) === ()
+    if representation_size(M.manifold) === () && length(x) > 0
         return allocate(x[1])
     else
         return [
@@ -209,8 +209,12 @@ function allocate_result(M::PowerManifoldNested, f, x...)
         ]
     end
 end
-function allocate_result(::PowerManifoldNestedReplacing, f, x...)
-    return copy(x[1])
+function allocate_result(M::PowerManifoldNestedReplacing, f, x...)
+    if length(x) == 0
+        return [allocate_result(M.manifold, f) for _ in get_iterator(M)]
+    else
+        return copy(x[1])
+    end
 end
 
 for PowerRepr in [PowerManifoldNested, PowerManifoldNestedReplacing]

src/bases.jl

@@ -318,7 +318,7 @@ end
 @inline function allocate_result_type(
     M::AbstractManifold,
     f::Union{typeof(get_coordinates),typeof(get_vector)},
-    args::Tuple,
+    args::Tuple{Any,Vararg{Any}},
 )
     apf = allocation_promotion_function(M, f, args)
     return apf(

src/numbers.jl

@@ -36,6 +36,14 @@ const ℝ = RealNumbers()
 const ℂ = ComplexNumbers()
 const ℍ = QuaternionNumbers()
 
+@inline function allocate_result_type(
+    ::AbstractManifold{ℂ},
+    f::TF,
+    args::Tuple{},
+) where {TF}
+    return ComplexF64
+end
+
 """
     _unify_number_systems(𝔽s::AbstractNumbers...)
 

test/allocation.jl

@@ -1,7 +1,7 @@
 using ManifoldsBase
 using Test
 using ManifoldsBase:
-    combine_allocation_promotion_functions, allocation_promotion_function, ℝ
+    combine_allocation_promotion_functions, allocation_promotion_function, ℝ, ℂ
 
 struct AllocManifold{𝔽} <: AbstractManifold{𝔽} end
 AllocManifold() = AllocManifold{ℝ}()
@@ -16,6 +16,9 @@ end
 struct AllocManifold2 <: AbstractManifold{ℝ} end
 ManifoldsBase.representation_size(::AllocManifold2) = (2, 3)
 
+struct AllocManifold3 <: AbstractManifold{ℂ} end
+ManifoldsBase.representation_size(::AllocManifold3) = (2, 3)
+
 @testset "Allocation" begin
     a = [[1.0], [2.0], [3.0]]
     b = [[2.0], [3.0], [-3.0]]
@@ -58,4 +61,6 @@ ManifoldsBase.representation_size(::AllocManifold2) = (2, 3)
     alloc2 = ManifoldsBase.allocate_result(AllocManifold2(), rand)
     @test alloc2 isa Matrix{Float64}
     @test size(alloc2) == representation_size(AllocManifold2())
+
+    @test ManifoldsBase.allocate_result(AllocManifold3(), rand) isa Matrix{ComplexF64}
 end

test/power.jl

@@ -155,5 +155,8 @@ power_array_wrapper(::Type{NestedReplacingPowerRepresentation}, i::Int) = SVecto
             DN = DummyDecorator(N)
             @test p[DN, 1] == p[N, 1]
         end
+        @testset "zero argument allocation" begin
+            @test size(ManifoldsBase.allocate_result(N, rand)) == size(p)
+        end
     end
 end