Allow copying scalars (#154)

* Allow copying scalars

* minor change

* missing test

Project.toml

@@ -1,7 +1,7 @@
 name = "ManifoldsBase"
 uuid = "3362f125-f0bb-47a3-aa74-596ffd7ef2fb"
 authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
-version = "0.14.3"
+version = "0.14.4"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/ManifoldsBase.jl

@@ -263,7 +263,7 @@ function check_size(M::AbstractManifold, p, X)
 end
 
 @doc raw"""
-    copy(M, p)
+    copy(M::AbstractManifold, p)
 
 Copy the value(s) from the point `p` on the [`AbstractManifold`](@ref) `M` into a new point.
 See [`allocate_result`](@ref) for the allocation of new point memory and [`copyto!`](@ref) for the copying.
@@ -273,9 +273,12 @@ function copy(M::AbstractManifold, p)
     copyto!(M, q, p)
     return q
 end
+function copy(::AbstractManifold, p::Number)
+    return copy(p)
+end
 
 @doc raw"""
-    copy(M, p, X)
+    copy(M::AbstractManifold, p, X)
 
 Copy the value(s) from the tangent vector `X` at a point `p` on the
 [`AbstractManifold`](@ref) `M` into a new tangent vector.
@@ -287,6 +290,9 @@ function copy(M::AbstractManifold, p, X)
     copyto!(M, Y, p, X)
     return Y
 end
+function copy(::AbstractManifold, p, X::Number)
+    return copy(X)
+end
 
 
 @doc raw"""

test/default_manifold.jl

@@ -857,4 +857,12 @@ Base.size(x::MatrixVectorTransport) = (size(x.m, 2),)
     @testset "performance" begin
         @allocated isapprox(M, SA[1, 2], SA[3, 4]) == 0
     end
+
+    @testset "scalars" begin
+        M = DefaultManifold()
+        p = 1.0
+        X = 2.0
+        @test copy(M, p) === p
+        @test copy(M, p, X) === X
+    end
 end