Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cubic Hermite interpolation #5

Merged
merged 14 commits into from
Sep 23, 2024
Merged

Conversation

mateuszbaran
Copy link
Member

I've made the first example. This repository didn't look particularly inviting being empty 🙂 .

@mateuszbaran
Copy link
Member Author

@kellertuer Do you know why quarto can't find the Julia kernel here on CI?

ERROR: Jupyter kernel 'julia-1.10' not found. Known kernels: python3. Run 'quarto check jupyter' with your python environment activated to check python version used.

I've tried a few things from other repositories but nothing solved this.

@kellertuer
Copy link
Member

kellertuer commented Sep 6, 2024

I can check later today. Without checking it out – the error message reads like iJulia was not compiled in that env (maybe the wrong one was chosen?).

Yes that is why this is also not registered and such; I did not yet find time to move examples like the Bezier one here.

@mateuszbaran
Copy link
Member Author

Thanks! I was working on JuliaManifolds/ManifoldDiffEq.jl#8 and decided that, since I'm already investigating how it works, I could as well make an example out of it.

@kellertuer
Copy link
Member

make.jl now correctly makes sure quarto can be run (IJulia is precompiled), but your example run on quarto currently misses PythonPlot.

Shall we maybe in general switch to using Makie? I was thinking about maybe removing the receipts from Manifolds soon-ish when we have a ManifoldsMakie-or-so package (I think I have nice sphere plots in Makie soon)

@kellertuer
Copy link
Member

Thanks!

No problem currently the quarto setup is not that easy and here we still had a bit of an old style (without CondaPkg) – so I hope now that starts fine on CI as well (but will still fail on PythonPlot) – maybe check what is missing in the examples/ environment – or do your own in a subfolder for the example maybe (leave the notebook in the examples/ folder but internally activate the env from the subfolder)

@kellertuer
Copy link
Member

One could of course argue whether this is a Manifolds example or a ManifoldDiff example. But maybe that is just a matter of perspective. If the “thing on the manifold” or the manifold itself is in the center, we could surely put it here.

@mateuszbaran
Copy link
Member Author

your example run on quarto currently misses PythonPlot.

That's very likely. I have issues running quarto on my PC (it usually freezes my entire desktop environment) so here I was just fixing errors as they appeared on CI.

Shall we maybe in general switch to using Makie? I was thinking about maybe removing the receipts from Manifolds soon-ish when we have a ManifoldsMakie-or-so package (I think I have nice sphere plots in Makie soon)

I'm not sure. Plots.jl is nice because it's more snappy than Makie.jl (or at least it was the last time I checked). Makie on the other hand can make more fancy 3D visualizations. I'm fine with extending Makie support but maybe let's wait with removing Plots stuff until we see Makie works for us? We can use both in the meantime.

One could of course argue whether this is a Manifolds example or a ManifoldDiff example. But maybe that is just a matter of perspective. If the “thing on the manifold” or the manifold itself is in the center, we could surely put it here.

Well, let's maybe not split "Examples" packages that much. This one can serve both Manifolds and ManifoldDiff.

@kellertuer
Copy link
Member

Sure, we can also categorise the examples here at some point.

The thought mainly came from that we have ManoptExamples already – but we should not to a XExamples for every of our packages. So sure, let's keep them here and maybe do an advanced menu or an overview page when that becomes necessary

@mateuszbaran
Copy link
Member Author

IIRC this is ready so maybe we could merge it?

@mateuszbaran mateuszbaran added the Ready-for-Review A label for pull requests that are feature-ready label Sep 23, 2024
Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, and then register a first version of this.

@mateuszbaran mateuszbaran merged commit 084ec61 into main Sep 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants