Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retrying normalization if necessary. #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RomeoV
Copy link

@RomeoV RomeoV commented Nov 1, 2023

See #25.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 80.75%. Comparing base (d55da16) to head (d3cc117).
Report is 10 commits behind head on master.

Files Patch % Lines
src/svd.jl 9.09% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   85.03%   80.75%   -4.29%     
==========================================
  Files           4        4              
  Lines         254      265      +11     
==========================================
- Hits          216      214       -2     
- Misses         38       51      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasnoack andreasnoack self-requested a review November 3, 2023 11:55
@ViralBShah
Copy link
Contributor

@RomeoV Apologies coming back to this after such a long time. Is it still useful to get this added? If it helps, I'm happy to invite you to have commit access to this package (which hopefully doesn't move much).

@andreasnoack andreasnoack reopened this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants