InteractiveUtils.jl: fixes issue where subtypes resolves bindings and causes deprecation warnings #56306
+21
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
subtypes
will throw deprecation errors even if no one is using the deprecated bindings.A similar bug was fixed in Aqua.jl - https://github.com/JuliaTesting/Aqua.jl/pull/89/files
See discussion here:
This adds the
isbindingresolved
test to thesubtypes
function to avoid throwing deprecation warnings. It also adds a test to check that this doesn't happen.On the current master branch (before the fix), the added test shows:
Using the results of this pull request:
passes without error. The other tests pass too.