Adding support for MMTk (non-moving immix) #56288
Draft
+1,512
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art of the refactoring
…art of the refactoring
…art of the refactoring
udesou
changed the title
gbaraldi
reviewed
Oct 22, 2024
Keno
reviewed
Oct 22, 2024
| @@ -2452,8 +2452,122 @@ void LateLowerGCFrame::PlaceRootsAndUpdateCalls(SmallVectorImpl<int> &Colors, St | |||
| } | |||
| } | |||
|
|
|||
| #ifdef MMTK_GC | |||
There was a problem hiding this comment.
I'd prefer it if this was a runtime option to the pass rather than a compiletime option.
There was a problem hiding this comment.
Do you mean choosing MMTk as a runtime option or inlining the fastpath as a runtime option? The former is not really possible, at least not at this point. The latter should be possible, with maybe a small overhead of checking the runtime option variable every time we're running that pass.
Keno
reviewed
Oct 23, 2024
| Value *callee = CI->getCalledOperand(); | ||
| assert(callee); | ||
|
|
||
| auto GCAllocBytes = getOrNull(jl_intrinsics::GCAllocBytes); |
There was a problem hiding this comment.
You should be able to just iterate over users of this global rather than iterating through all statements, which is slow.
…and jl_atomic_store_relaxed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility of building/running Julia using MMTk, running non-moving immix.
The binding code (Rust) associated with it is in https://github.com/mmtk/mmtk-julia/tree/upstream-ready/immix. Instructions on how to build/run Julia with MMTk are described in the
READMEfile inside the binding repo.