[REPL] fix lock ordering mistake in load_pkg #56215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix waiting on the package_locks being always a no-op here. Fixes #56206
vtjnash
added
REPL
Comment on lines
+6
to
-8
| REPLExt = Base.require_stdlib(Pkg_pkgid, "REPLExt") | ||
| @lock Base.require_lock begin | ||
| REPLExt = Base.require_stdlib(Pkg_pkgid, "REPLExt") |
There was a problem hiding this comment.
require_stdlib locks require_lock for the entire function, so why does the lock need to be released between these operations?
There was a problem hiding this comment.
It releases the lock many times internally
There was a problem hiding this comment.
Ah so the additional lock layer prevents those from releasing fully
There was a problem hiding this comment.
Yes. We could do an unlockall/relockall pair like wait does, but it is sort of always a concurrency bug if your application actually relies on that.
IanButterworth
approved these changes
Oct 17, 2024
KristofferC
pushed a commit
that referenced
this pull request
Oct 18, 2024
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56206